Skip to content

Change YAML config to PHP #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
OndraM opened this issue Nov 27, 2020 · 0 comments · Fixed by #56
Closed
2 tasks done

Change YAML config to PHP #51

OndraM opened this issue Nov 27, 2020 · 0 comments · Fixed by #56
Milestone
3.0

Comments

@OndraM
Copy link
Contributor

OndraM commented Nov 27, 2020 •
edited
Loading

Unfortunately, another breaking change introduced by easy-coding-standard (ECS)...

As part of deprecated-packages/symplify#2008, they switched from easy-coding-standard.yaml to config in PHP file ecs.php. YAML was deprecated in ECS 8.1.21 (the deprecation always comes with sleep 3 to force anyone to upgrade 🤦 ). It was removed in ECS 9.

TODO
@OndraM OndraM added this to the 3.0 milestone Nov 27, 2020
@PilarJ PilarJ mentioned this issue Feb 1, 2021
Closed
OndraM added a commit that referenced this issue Feb 4, 2021
@OndraM
Upgrade to ECS 9 with PHP config (fixes #50, #51)
617756f 
Co-authored-by: Jakub Pilař <[email protected]>
@OndraM OndraM linked a pull request Feb 4, 2021 that will close this issue
Upgrade to ECS 9 with PHP config #56
Merged
@OndraM OndraM mentioned this issue Feb 4, 2021
Merged
OndraM added a commit that referenced this issue Feb 4, 2021
@OndraM
fixup! Upgrade to ECS 9 with PHP config (fixes #50, #51)
e2465e6
OndraM added a commit that referenced this issue Feb 5, 2021
@OndraM
Upgrade to ECS 9 with PHP config (fixes #50, #51)
85733e3 
Co-authored-by: Jakub Pilař <[email protected]>
This was referenced Feb 8, 2021
Closed
Merged
@OndraM OndraM closed this as completed in #56 Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Upgrade to ECS 9 with PHP config alma-oss/php-coding-standard
1 participant
@OndraM