Bump capi and vcluster #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesfrey
force-pushed
the
bump-capi-and-vcluster
branch
from
dc53488 to
bf1871d
Compare
johannesfrey
force-pushed
the
bump-capi-and-vcluster
branch
3 times, most recently
from
ee0211c to
971b223
Compare
johannesfrey
force-pushed
the
bump-capi-and-vcluster
branch
from
f7388e1 to
028a0d4
Compare
cbron
approved these changes
Nov 18, 2024
cbron
left a comment
cbron
left a comment
There was a problem hiding this comment.
Reviewed and it lgtm, though I am not familiar with context here.
johannesfrey
force-pushed
the
bump-capi-and-vcluster
branch
from
028a0d4 to
2d0e8fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthermore, this PR bumps go to 1.23 (to be aligned with vcluster 0.21) and switches golangci-lint to use modules.
Resolves ENG-4144