chore: move go e2e test to workflow file and remove dependency to vcluster code base #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesfrey
force-pushed
the
delete-test-remove-vcluster-dep
branch
from
a8c6045 to
a95cab0
Compare
johannesfrey
changed the title
johannesfrey
force-pushed
the
delete-test-remove-vcluster-dep
branch
from
a95cab0 to
4cbed94
Compare
johannesfrey
force-pushed
the
delete-test-remove-vcluster-dep
branch
from
4cbed94 to
958b117
Compare
johannesfrey
changed the title
This was referenced Jan 21, 2025
cbron
approved these changes
Jan 21, 2025
cbron
left a comment
cbron
left a comment
There was a problem hiding this comment.
LGTM as a concept. Keeping all e2e tests disconnected from vcluster library and only using CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ENG-5220