chore: use latest if CHART_VERSION is not set #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesfrey
force-pushed
the
use-latest-when-no-chartversion
branch
from
874ff27 to
a3db1c9
Compare
johannesfrey
force-pushed
the
use-latest-when-no-chartversion
branch
from
a3db1c9 to
f16efc4
Compare
This was referenced Jan 29, 2025
Contributor
Author
|
Closing in favor of #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ENG-3957
Instead of explicitly bumping the CHART_VERSION (triggered from a vcluster release, see: loft-sh/vcluster#2417 and #95), this PR changes the logic so that the controller will use the latest stable vcluster chart when CHART_VERSION is omitted.
Depending on what we decide on, we should close the alternative solution accordingly.
TODO after merge: