feat: add Globalping support#6163
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
@CommanderStorm this is ready for the final review. We'll make a PR for the wiki once this is merged. Let me know if there's anything that needs to be changed. Thanks. For the |
|
Let us know if there is anything we can do to help the review go smoother! |
There was a problem hiding this comment.
Given the size of the PR, I will need to part time this one, but as this is +1k lines, I think this is understandable.
In this PR, I reviewed the backend and the frontend will be another Review.
I have to say, I am very positively suppried by the level of depth you went for. There are a lot of places which I would have missed on this one.
For the backend, please move the DNS monitor to another PR, I don't think that integrates well against our existing internal API and might need either splitting or a better API.
|
@jimaek
I am not entirely sure what you and Radu's relationship is, if you are both working for/on the JSDeliver, feel free to ignore |
|
Yep we're working together on Globalping. So I already tested his PR before he sent it. We tried to prepare a polished experience Thanks for the feedback, we will start working on it shortly 😃 |
|
@CommanderStorm let me know if there's anything else. Thanks. |
|
Hey, with time syncing with master will probably get harder and harder with more conflicts. It would be great if we could merge this to focus more on new features and prepare the next PR :) |
marcispauls
left a comment
There was a problem hiding this comment.
Reviewed locally, great job guys.
Of course there might be some polishing needed, but lets finally merge this :)
|
Yay! Its missing the DNS functionality, so any feedback you have we can add it to our next PR along with DNS |
|
Hey all, I think this PR is ready! |
CommanderStorm
left a comment
There was a problem hiding this comment.
Frontend LGTM. Sorry for the late review, XL-sized PRs take longer for me to have the time for currently.
We can merge, assuming the code duplication issues in the frontend are merged and this is merged with master.
| <input | ||
| id="hostname" | ||
| v-model="monitor.hostname" | ||
| type="text" | ||
| class="form-control" | ||
| :pattern="ipOrHostnameRegexPattern" | ||
| required | ||
| data-testid="hostname-input" | ||
| > | ||
| <div class="form-text"> | ||
| {{ $t("GlobalpingHostname") }} | ||
| </div> |
There was a problem hiding this comment.
please merge this with the field the ping monitor uses for this.
This way, we can reuse the new, more accurate validation logic for this.
Keep the helptext, that is good.
There was a problem hiding this comment.
It has a different pattern. I put most of the globalping logic into a separate template/fields to keep things simple and independent of other features even if there's a bit of duplicated code.
73d0192 to
9052d01
Compare
|
@radulucut congrats on your first contribution to Uptime Kuma! 🐻 |
|
@jimaek This seems to be a related issue caused by this PR |
|
Actually, just going from nightly to nightly does not have any stability guarnntees. |

📋 Overview
This is PR adds support for Globalping.
Globalping is a free and open-source tool that allows you to run network tests and measurements from thousands of community hosted probes around the world.
The following commands are available via the new
Globalpingmonitor:ping,http,dns.Check out the API documentation for additional information.
🛠️ Type of change
📄 Checklist
📷 Screenshots or Visual Changes
Ping
HTTP
DNS
General settings