fix: Clarify domain expiry warning for TLDs without RDAP endpoints#6620
fix: Clarify domain expiry warning for TLDs without RDAP endpoints#6620CommanderStorm merged 2 commits intomasterfrom
Conversation
…ndpoint Co-authored-by: CommanderStorm <26258709+CommanderStorm@users.noreply.github.com>
|
@copilot all logs in this file say log.error("domain", log.warn("domain" or log.debug("domain" They should be log.error("domain_expiry" and such |
There was a problem hiding this comment.
Pull request overview
This PR improves the warning message for TLDs that don't have RDAP endpoints listed in the IANA database. The previous message incorrectly suggested users should file a bug report when monitoring was unavailable for certain legitimate TLDs like .eu, .gr, and .pf.
Key Changes:
- Rewrote warning message to explain that domain expiry monitoring is unsupported due to missing RDAP endpoint in IANA database
- Added dot prefix to TLD (
.euinstead ofeu) for better clarity - Removed misleading "file a bug report" suggestion that was causing confusion
| const rdap = await getRdapServer(tld.publicSuffix); | ||
| if (!rdap) { | ||
| log.warn("domain", `${tld.publicSuffix} is not supported. File a bug report if you believe it should be.`); | ||
| log.warn("domain", `Domain expiry unsupported for '.${tld.publicSuffix}' because its RDAP endpoint is not listed in the IANA database.`); |
There was a problem hiding this comment.
There's another similar warning message on line 51 that could benefit from the same clarity improvement. Currently it says "No RDAP server found, TLD ${tld} not supported." but it doesn't include the dot prefix for consistency. Consider updating it to match the new format: "Domain expiry unsupported for '.${tld}' because its RDAP endpoint is not listed in the IANA database."
This is a good log improvement, since it allowed me to quickly find the source of endless log warning entries showing: When watching the log while entering a domain name, I notice that every new character entered in the input field generates a new warn log line. Are there any good reasons for logging at that level, or repeatedly logging unrecognized domain names at every heartbeat? I can see several reasons for using unrecognized domains. In corporate environments, the DNS could be configured with split horizon where a private domain is for intranet use, and there could even be unusual names in /etc/hosts. For my own use, I prefer IP addresses for simplicity (yes really), and that generates those endless log lines. |
No, that is a bug. I am not sure why for you there are all of thee entries, did you create a new monitor or have to save for each line |
To clarify a bit. |
|
I guess then that part is also a bug |
Another observation: Monitor pages created previous to this PR does not have the new 'Domain Name Expiry Notification' tick box. I don't know if it is supposed to be automatically updated. |
A more serious observation. This also happens when adding a Ping monitor. |
The warning message for TLDs without RDAP endpoints (
.eu,.gr,.pf, etc.) incorrectly suggested filing a bug report and didn't explain why domain expiry monitoring was unavailable.Changes:
server/model/domain_expiry.jsto explain that RDAP endpoint is missing from IANA database.euinstead ofeu) for clarityBefore:
After:
This affects TLDs that legitimately don't provide RDAP services and cannot be supported through the current implementation.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.