Skip to content

fix: Clarify domain expiry warning for TLDs without RDAP endpoints #6620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CommanderStorm merged 2 commits into from
Jan 6, 2026
Merged

fix: Clarify domain expiry warning for TLDs without RDAP endpoints #6620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d00144
Initial plan
Copilot Jan 6, 2026
ac121ad
Update domain expiry warning message to be more explicit about RDAP e…
Copilot Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/model/domain_expiry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class DomainExpiry extends BeanModel {
const tld = parseTld(urlTypes.includes(m.type) ? m.url : m.type === "grpc-keyword" ? m.grpcUrl : m.hostname);
const rdap = await getRdapServer(tld.publicSuffix);
if (!rdap) {
log.warn("domain", `${tld.publicSuffix} is not supported. File a bug report if you believe it should be.`);
log.warn("domain", `Domain expiry unsupported for '.${tld.publicSuffix}' because its RDAP endpoint is not listed in the IANA database.`);
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another similar warning message on line 51 that could benefit from the same clarity improvement. Currently it says "No RDAP server found, TLD ${tld} not supported." but it doesn't include the dot prefix for consistency. Consider updating it to match the new format: "Domain expiry unsupported for '.${tld}' because its RDAP endpoint is not listed in the IANA database."

Copilot uses AI. Check for mistakes.
return false;
}
const existing = await DomainExpiry.findByName(tld.domain);
Expand Down
Loading