feat(semver-compare): add new Github action #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new Github Action that semantically compares two versions, like 2.1.1 and 2.3.0 giving information about whether or the version is "higher" or "lower" than another version. The action exposes an output called `result` which will match the return type of the PHP [version_compare](https://www.php.net/manual/en/function.version-compare.php) function. Currently, this action compares `version` against `compare_against` and returns: - `-1` - if `version` is lower than `compare_against` - `0` - if `version` is equal to `compare_against` - `1` - if `version` is greater than `compare_against` Co-authored-by: Vitaliy Golomoziy <[email protected]>
damienwebdev
force-pushed
the
vit_split_3
branch
from
c458e43 to
df7e778
Compare
Vinai
reviewed
Sep 21, 2023
There was a problem hiding this comment.
The PHP function version_compare doesn't handle -p patch suffixes according to how they are used by Adobe.
The function sorts them before instead of after the version.
Since it is likely we will be using this with Magento's versioning, should we improve on this?
13 tasks
Vinai
approved these changes
Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, we don't have a way to compare semver versions making handling BC issues a challenge.
Touches #132
What is the new behavior?
This adds a new Github Action that semantically compares two versions, like 2.1.1 and 2.3.0 giving information about whether or the version is "higher" or "lower" than another version. The action exposes an output called
resultwhich will match the return type of the PHP version_compare function.Currently, this action compares
versionagainstcompare_againstand returns:-1- ifversionis lower thancompare_against0- ifversionis equal tocompare_against1- ifversionis greater thancompare_againstDoes this PR introduce a breaking change?
Other information