Skip to content

feat(coding-standard): add ignore_warnings flag #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Sep 21, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

By default, phpcs exits with a non-zero exit code when it finds warnings. Additionally, we fixed an issue with older versions of composer.

Fixes: #130
Supersedes: #132

What is the new behavior?

  • We expose a new input called ignore_warnings that causes them to be reported, but still exit 0
  • We both test against and fix an issue with older versions of composers that don't have plugins.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

By default, `phpcs` exits with a non-zero exit code when it finds warnings. We keep that default, but allow changing it.

Co-authored-by: Vitaliy Golomoziy <[email protected]>
@damienwebdev
Copy link
Member Author

Awaiting #146 before merge!

@damienwebdev damienwebdev merged commit 4e21b18 into mage-os:main Sep 21, 2023
@damienwebdev damienwebdev deleted the coding_Standard branch September 21, 2023 12:41
@mage-os-ci mage-os-ci mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add new fail_on_warnings to the coding-standard action
2 participants