🔃 [EngCom] Public Pull Requests - 2.1-develop

Accepted Public Pull Requests:
 - magento/magento2#15767: [Backport] FIX fo rissue #15510 - First PDF download / export after login (by @sanjay-wagento)
 - magento/magento2#15797: [Backport] Removed unnecessary css. #3 (by @chirag-wagento)
 - magento/magento2#15796: [Backport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento/magento2#15801: [Backport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @viral-wagento)
 - magento/magento2#15855: [Backport 2.1] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento/magento2#15841: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� #15 (by @chirag-wagento)
 - magento/magento2#15776: [Backport] Added additional headers for avoiding customer data caching (by @rogyar)


Fixed GitHub Issues:
 - magento/magento2#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento/magento2#15767 by @sanjay-wagento in 2.1-develop branch
   Related commits:
     1. 8e43c07

 - magento/magento2#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento/magento2#15796 by @hitesh-wagento in 2.1-develop branch
   Related commits:
     1. d3184ac

Author: VladimirZaets

app/code/Magento/Backend/App/AbstractAction.php

@@ -214,6 +214,7 @@ public function dispatch(\Magento\Framework\App\RequestInterface $request)
             $this->_view->loadLayout(['default', 'adminhtml_denied'], true, true, false);
             $this->_view->renderLayout();
             $this->_request->setDispatched(true);
+
             return $this->_response;
         }
 
@@ -223,6 +224,11 @@ public function dispatch(\Magento\Framework\App\RequestInterface $request)
 
         $this->_processLocaleSettings();
 
+        // Need to preload isFirstPageAfterLogin (see https://github.com/magento/magento2/issues/15510)
+        if ($this->_auth->isLoggedIn()) {
+            $this->_auth->getAuthStorage()->isFirstPageAfterLogin();
+        }
+
         return parent::dispatch($request);
     }
 

app/code/Magento/Catalog/view/frontend/web/js/catalog-add-to-cart.js

@@ -33,6 +33,10 @@ define([
 
         _bindSubmit: function() {
             var self = this;
+            if (this.element.data('catalog-addtocart-initialized')) {
+                return;
+            }
+            this.element.data('catalog-addtocart-initialized', 1);
             this.element.on('submit', function(e) {
                 e.preventDefault();
                 self.submitForm($(this));

app/code/Magento/Customer/Controller/Section/Load.php

@@ -61,6 +61,8 @@ public function execute()
     {
         /** @var \Magento\Framework\Controller\Result\Json $resultJson */
         $resultJson = $this->resultJsonFactory->create();
+        $resultJson->setHeader('Cache-Control', 'max-age=0, must-revalidate, no-cache, no-store', true);
+        $resultJson->setHeader('Pragma', 'no-cache', true);
         try {
             $sectionNames = $this->getRequest()->getParam('sections');
             $sectionNames = $sectionNames ? array_unique(\explode(',', $sectionNames)) : null;

app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows-grid.js

@@ -104,9 +104,8 @@ define([
          * @param {String|Number} recordId
          */
         deleteRecord: function (index, recordId) {
-            this._super();
-
             this.updateInsertData(recordId);
+            this._super();
         },
 
         /**

app/code/Magento/Wishlist/Block/Rss/EmailLink.php

@@ -22,7 +22,7 @@ class EmailLink extends Link
     protected $_template = 'rss/email.phtml';
 
     /**
-     * @return string
+     * @return array
      */
     protected function getLinkParams()
     {

app/code/Magento/Wishlist/Block/Rss/Link.php

@@ -69,7 +69,7 @@ public function isRssAllowed()
     }
 
     /**
-     * @return string
+     * @return array
      */
     protected function getLinkParams()
     {

app/code/Magento/Wishlist/Helper/Data.php

@@ -500,7 +500,7 @@ public function isAllowInCart()
     /**
      * Retrieve customer name
      *
-     * @return string|void
+     * @return string|null
      */
     public function getCustomerName()
     {

app/design/frontend/Magento/luma/web/css/source/_actions-toolbar.less

@@ -22,10 +22,6 @@
                 &:last-child {
                     margin-bottom: 0;
                 }
-
-                &.primary {
-                    //  &:extend(.abs-button-l all);
-                }
             }
 
             &:last-child {

app/design/frontend/Magento/luma/web/css/source/_forms.less

@@ -91,11 +91,7 @@
     .select-styling() {
         .lib-css(appearance, none, 1);
         appearance: none;
-        background: @select__background url('../images/select-bg.svg') no-repeat 100% 45%;
         background-size: 30px 60px;
-        border: 1px solid @border-color__base;
-        height: 32px;
-        padding-right: 25px;
         text-indent: .01em;
         text-overflow: '';
 

app/design/frontend/Magento/luma/web/css/source/_theme.less

@@ -153,6 +153,13 @@
 //  Forms
 //  ---------------------------------------------
 
+
+//  Select
+@select__background: @form-element-input__background url('../images/select-bg.svg') no-repeat 100% 45%;
+@select__border: 1px solid @border-color__base;
+@select__height: 32px;
+@select__padding: 4px 25px @indent__xs @indent__s;
+
 //  Form fieldset
 @form-fieldset-legend__font-size: 18px;
 @form-fieldset-legend__font-weight: @font-weight__light;

dev/tests/static/framework/Magento/Sniffs/Less/PropertiesSortingSniff.php

@@ -101,7 +101,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     private function validatePropertiesSorting(PHP_CodeSniffer_File $phpcsFile, $stackPtr, array $properties)
     {
         // Fix needed for cases when incorrect properties passed for validation due to bug in PHP tokens.
-        $symbolsForSkip = ['(', 'block'];
+        $symbolsForSkip = ['(', 'block', 'field'];
         $properties = array_filter(
             $properties,
             function ($var) use ($symbolsForSkip) {

lib/web/css/source/lib/variables/_forms.less

@@ -121,7 +121,7 @@
 @select__disabled__font-style: @form-element-input__disabled__font-style;
 
 //  Focus state
-@select__focus__background: @form-element-input__focus__background;
+@select__focus__background: false;
 @select__focus__border: @form-element-input__focus__border;
 @select__focus__color: @form-element-input__focus__color;
 @select__focus__font-style: @form-element-input__focus__font-style;