Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Update PHP version dependency to ~7.2.0 #15

Closed
buskamuza opened this issue Dec 27, 2017 · 3 comments
Closed

Update PHP version dependency to ~7.2.0 #15

buskamuza opened this issue Dec 27, 2017 · 3 comments

Comments

@buskamuza
Copy link
Contributor

buskamuza commented Dec 27, 2017

Update composer.json to add PHP ~7.2.0:

AC:

  • use require-dev section, so Magento doesn't claim PHP 7.2 support until it's fully implemented and verified
  • existing tests (on PHP 7.1) are green
@pmclain
Copy link
Contributor

pmclain commented Jan 19, 2018

@buskamuza I can take this one.

pmclain pushed a commit to pmclain/php-7.2-support that referenced this issue Jan 20, 2018
pmclain pushed a commit to pmclain/php-7.2-support that referenced this issue Jan 20, 2018
@buskamuza buskamuza assigned buskamuza and pmclain and unassigned buskamuza Jan 25, 2018
@buskamuza
Copy link
Contributor Author

@pmclain , I've added you to the project and assigned the task.

pmclain pushed a commit to pmclain/php-7.2-support that referenced this issue Jan 29, 2018
pmclain pushed a commit to pmclain/php-7.2-support that referenced this issue Jan 31, 2018
pmclain pushed a commit to pmclain/php-7.2-support that referenced this issue Feb 11, 2018
pmclain pushed a commit to pmclain/php-7.2-support that referenced this issue Feb 11, 2018
@buskamuza buskamuza added this to the Magento 2.3.0 milestone Mar 7, 2018
@buskamuza
Copy link
Contributor Author

To be done in #86

@buskamuza buskamuza reopened this Mar 29, 2018
magento-engcom-team added a commit that referenced this issue Jun 6, 2018
…ot read property source_… #15 #15841

 - Merge Pull Request magento/magento2#15841 from chirag-wagento/magento2:2.1-develop-PR-port-14805
 - Merged commits:
   1. 68e19af
magento-engcom-team pushed a commit that referenced this issue Jun 6, 2018
magento-engcom-team pushed a commit that referenced this issue Jun 6, 2018
Accepted Public Pull Requests:
 - magento/magento2#15767: [Backport] FIX fo rissue #15510 - First PDF download / export after login (by @sanjay-wagento)
 - magento/magento2#15797: [Backport] Removed unnecessary css. #3 (by @chirag-wagento)
 - magento/magento2#15796: [Backport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento/magento2#15801: [Backport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @viral-wagento)
 - magento/magento2#15855: [Backport 2.1] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento/magento2#15841: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� #15 (by @chirag-wagento)
 - magento/magento2#15776: [Backport] Added additional headers for avoiding customer data caching (by @rogyar)


Fixed GitHub Issues:
 - magento/magento2#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento/magento2#15767 by @sanjay-wagento in 2.1-develop branch
   Related commits:
     1. 8e43c07

 - magento/magento2#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento/magento2#15796 by @hitesh-wagento in 2.1-develop branch
   Related commits:
     1. d3184ac
magento-engcom-team pushed a commit that referenced this issue Sep 11, 2018
magento-engcom-team added a commit that referenced this issue Sep 25, 2018
… adding mergi… #15

 - Merge Pull Request magento-commerce/async-import#15 from comwrap/async-import:support-HTTP_DELETE-for-bulk
 - Merged commits:
   1. 9ec6db2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants