Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

pelago/emogrifier does not support PHP 7.2 #3

Closed
buskamuza opened this issue Dec 22, 2017 · 3 comments
Closed

pelago/emogrifier does not support PHP 7.2 #3

buskamuza opened this issue Dec 22, 2017 · 3 comments
Labels
3rd-party dependency backward-incompatible blocker

Comments

@buskamuza
Copy link
Contributor

buskamuza commented Dec 22, 2017 •
edited
Loading

Update pelago/emogrifier (https://github.com/MyIntervals/emogrifier) to the version that supports PHP 7.2.

AC:

  • tests are green
  • usage scenarios are working

Ver. 2.0.0 supports 7.2
@buskamuza buskamuza changed the title Compatibility of pelago/emogrifier with PHP 7.2 pelago/emogrifier does not support PHP 7.2 Dec 22, 2017
@buskamuza
Copy link
Contributor Author

Closed in favor of #24

@buskamuza buskamuza reopened this Feb 8, 2018
@buskamuza buskamuza mentioned this issue Feb 8, 2018
Closed
@pmclain
Copy link
Contributor

pmclain commented Feb 11, 2018

@buskamuza Looks like this has already been done

php-7.2-support/composer.lock

Line 958 in 7ce6ffb

"version": "v2.0.0",

@ihor-sviziev
Copy link
Contributor

It was fixed in magento/magento2#13351. I think we can close this task

magento-engcom-team pushed a commit that referenced this issue Mar 6, 2018
Merge pull request #3 from magento/2.3-develop
ef0de42 
merge 2.3 develop into northernco
magento-team pushed a commit that referenced this issue May 2, 2018
@hatimeria-artur-jewula @Zefiryn
# This is a combination of 3 commits.
5f3ef1b 
# This is the 1st commit message:
#10765 add confirmation and lock_expires labels to customer grid CSV export

# This is the commit message #2:

#10765 Add tests for added methods

# This is the commit message #3:

10765 code refactoring
magento-engcom-team pushed a commit that referenced this issue May 3, 2018
@chris-pook
Merge pull request #3 from magento/2.2-develop
4567d1a 
Merging upstream
magento-engcom-team added a commit that referenced this issue Jun 6, 2018
@magento-engcom-team
ENGCOM-1854: [Backport] Removed unnecessary css. #3 #15797
79fa797 
 - Merge Pull Request magento/magento2#15797 from chirag-wagento/magento2:2.1-develop-PR-port-15789
 - Merged commits:
   1. 8bacebe
magento-engcom-team pushed a commit that referenced this issue Jun 6, 2018
ENGCOM-1854: [Backport] Removed unnecessary css. #3 #15797
2073969
magento-engcom-team pushed a commit that referenced this issue Jun 6, 2018
@VladimirZaets
🔃 [EngCom] Public Pull Requests - 2.1-develop
c07e5bb 
Accepted Public Pull Requests:
 - magento/magento2#15767: [Backport] FIX fo rissue #15510 - First PDF download / export after login (by @sanjay-wagento)
 - magento/magento2#15797: [Backport] Removed unnecessary css. #3 (by @chirag-wagento)
 - magento/magento2#15796: [Backport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento/magento2#15801: [Backport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @viral-wagento)
 - magento/magento2#15855: [Backport 2.1] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento/magento2#15841: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� #15 (by @chirag-wagento)
 - magento/magento2#15776: [Backport] Added additional headers for avoiding customer data caching (by @rogyar)


Fixed GitHub Issues:
 - magento/magento2#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento/magento2#15767 by @sanjay-wagento in 2.1-develop branch
   Related commits:
     1. 8e43c07

 - magento/magento2#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento/magento2#15796 by @hitesh-wagento in 2.1-develop branch
   Related commits:
     1. d3184ac
magento-engcom-team pushed a commit that referenced this issue Jun 25, 2018
@sanganinamrata
Merge pull request #3 from NamrataChangani/2.3-develop-PR-port-15825
083447a 
[Forwardport] Fixed set template syntax issue
magento-engcom-team pushed a commit that referenced this issue Jul 12, 2018
@Karlasa
Merge pull request #3 from Karlasa/2.1-develop-PR-port-16190
818519e 
[Backport] #16079 translation possibility for moreButtonText
magento-engcom-team pushed a commit that referenced this issue Aug 11, 2018
@yogeshks
Merge pull request #3 from Yogeshks/2.3-develop-PR-port-16354
b4ae5d6 
[Forwardport] Remove unnecessary translation of HTML tags
magento-engcom-team pushed a commit that referenced this issue Nov 6, 2018
@samuel27m
Merge pull request #3 from samuel27m/samuel27m-patch-3
2b2d4e2 
Backport [PR 18772] Remove unnecesary "header" block redeclaration
magento-engcom-team pushed a commit that referenced this issue Nov 24, 2018
@speedy008
Merge pull request #3 from magento/2.2-develop
7c013a1 
2.2 develop-update branch
magento-engcom-team pushed a commit that referenced this issue Dec 6, 2018
@khodu
Merge pull request #3 from magento/2.3-develop
dd965b9 
merge latest changes
magento-engcom-team pushed a commit that referenced this issue Dec 10, 2018
@ravi-chandra3197
Merge pull request #3 from magento/2.3-develop
78b694f 
merge request
magento-engcom-team pushed a commit that referenced this issue Jan 19, 2019
@niravkrish
Merge pull request #3 from magento/2.3-develop
c1d987b 
Pull 2.3 Latest
magento-engcom-team pushed a commit that referenced this issue Jan 31, 2019
@nirav-kadiya
Merge pull request #3 from magento/2.2-develop
8a059e6 
Update 2.2 develop
magento-engcom-team pushed a commit that referenced this issue Feb 20, 2019
@lisovyievhenii
Merge pull request #3 from magento/2.3-develop
eb0653c 
Fetch M2 last changes
magento-engcom-team pushed a commit that referenced this issue Mar 8, 2019
@DenisSaltanahmedov
Merge pull request #3 from magento/2.3-develop
2f1bc31 
update fork
magento-engcom-team pushed a commit that referenced this issue Mar 18, 2019
@Karlasa
Merge pull request #3 from magento/2.3-develop
e6167ad 
update fork
magento-engcom-team pushed a commit that referenced this issue Mar 25, 2019
@Dharmeshvaja91
Merge pull request #3 from magento/2.3-develop
f1e2fff 
Update Branch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3rd-party dependency backward-incompatible blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@buskamuza @ihor-sviziev @pmclain