Skip to content

[2.3] Update the Emogrifier dependency to ^2.0.0 #13351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2018
Merged

[2.3] Update the Emogrifier dependency to ^2.0.0 #13351

merged 1 commit into from
Feb 9, 2018

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Jan 24, 2018 •
edited by okorshenko
Loading

Description

Emogrifer 2.0.0 does not introduce any backwards-compatibilty-breaking
API changes. This version adds new features, fixes bugs and improves
the resulting HTML. So the update should be reasonably safe.

This is the 2.3-develop port of #13132.

Manual testing scenarios

  1. have Magento send an HTML email
  2. see that the generated email still looks okay

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@oliverklee oliverklee self-assigned this Jan 24, 2018
@oliverklee oliverklee requested a review from orlangur January 24, 2018 13:51
@oliverklee oliverklee mentioned this pull request Jan 24, 2018
Merged
4 tasks
@orlangur orlangur assigned orlangur and unassigned oliverklee Jan 24, 2018
@orlangur orlangur added this to the January 2018 milestone Jan 24, 2018
@oliverklee oliverklee changed the title Update the Emogrifier dependency to ^2.0.0 [2.3] Update the Emogrifier dependency to ^2.0.0 Feb 6, 2018
@oliverklee
Copy link
Contributor Author

Rebased and repushed.

@oliverklee
Copy link
Contributor Author

Oh, and another merge conflict. I'll take care of it.

@oliverklee
Update the Emogrifier dependency to ^2.0.0
3794b89 
Emogrifer 2.0.0 does not introduce any backwards-compatibilty-breaking
API changes. This version adds new features, fixes bugs and improves
the resulting HTML. So the update should be reasonably safe.
@oliverklee
Copy link
Contributor Author

Rebased and repushed.

@okorshenko okorshenko modified the milestones: January 2018, February 2018 Feb 7, 2018
@magento-engcom-team magento-engcom-team merged commit 3794b89 into magento:2.3-develop Feb 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2018
MAGETWO-87128: Update the Emogrifier dependency to ^2.0.0 #13351
a4fc618
@oliverklee oliverklee deleted the port/emogrifier-update branch February 9, 2018 09:48
@ihor-sviziev ihor-sviziev mentioned this pull request Feb 12, 2018
Closed
@Stevie-Ray Stevie-Ray mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverklee @orlangur @okorshenko @magento-engcom-team