Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Update PHP version dependency to ~7.2.0 #30

Closed
wants to merge 1 commit into from
Closed

Update PHP version dependency to ~7.2.0 #30

wants to merge 1 commit into from

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Jan 29, 2018 •
edited by buskamuza
Loading

Description

Add PHP 7.2 to require of all composer.json files.

Fixed Issues (if relevant)

  1. Update PHP version dependency to ~7.2.0 #15

Manual testing scenarios

  1. Checkout branch or clone repository
  2. Run composer install
  3. Installation should fail, but not due to Magento's PHP version constraints.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@pmclain pmclain force-pushed the req-dev/php72 branch 2 times, most recently from 9d76f61 to 4125120 Compare February 11, 2018 18:18
@buskamuza buskamuza mentioned this pull request Feb 12, 2018
Closed
4 tasks
@buskamuza buskamuza mentioned this pull request Feb 28, 2018
Merged
4 tasks
@pmclain
Copy link
Contributor Author

pmclain commented Mar 1, 2018

These changes are no longer current since PHP support settled on ~7.1.3||~7.2.0. Updating the version requires in #86.

@pmclain pmclain closed this Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buskamuza buskamuza buskamuza approved these changes

@giabmf11 giabmf11 giabmf11 approved these changes

Assignees
No one assigned
Labels
requires-b2b-changes requires-ee-changes requires-updater-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmclain @buskamuza @giabmf11