Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Update zendframework/zend-code #93

Closed
buskamuza opened this issue Mar 14, 2018 · 2 comments
Closed

Update zendframework/zend-code #93

buskamuza opened this issue Mar 14, 2018 · 2 comments
Assignees

Comments

@buskamuza
Copy link
Contributor

buskamuza commented Mar 14, 2018

Important: Use libs-upgrade branch as base for this task and as target for the PR.

AC:

  • zendframework/zend-code is updated to the latest MINOR version (3.3.0)
  • the dependency is declared so that MINOR version is fixed (~3.3.0 instead of ^3.3.0). Reason: there are differences in behavior between minor versions of this component
  • available tests (both internal and Travis CI) are green
@maxbucknell
Copy link
Contributor

I am working on this #distributed-cd

@maxbucknell maxbucknell self-assigned this Mar 24, 2018
maxbucknell added a commit to maxbucknell/php-7.2-support that referenced this issue Mar 24, 2018
- Update `zendframework/zend-code` to `~3.3.0`
@maxbucknell
Copy link
Contributor

Seems that most of the issues are related to zendframework/zend-code updating to use short array syntax. Since this syntax is used throughout the core, I am updating the tests to use the appropriate array syntax, this fixes the issue.

Will push these when they are finished, which will likely be next week. No other large issues have made themselves visible yet.

bbatsche pushed a commit that referenced this issue Mar 30, 2018
- Update `zendframework/zend-code` to `~3.3.0`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants