Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Update zendframework/zend-code #101

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

maxbucknell
Copy link
Contributor

  • Update zendframework/zend-code to ~3.3.0

Description

As per the issue (#93), update the dependency on zendframework/zend-code to ~3.3.0.

Fixed Issues (if relevant)

  1. Update zendframework/zend-code #93: Update zendframework/zend-code

Manual testing scenarios

Shouldn't be any testing required. The site still seems to function normally, but all tests should run to check for regressions.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- Update `zendframework/zend-code` to `~3.3.0`
@maxbucknell
Copy link
Contributor Author

The Travis build came back with some errors in generation. I will review these and see if they are significant, or whether we can just update the tests. (For only whitespace, and other syntactically insignificant changes.)

@buskamuza
Copy link
Contributor

One difference that I observed is a difference in arrays representation: array() vs []

@bbatsche bbatsche mentioned this pull request Mar 30, 2018
4 tasks
@buskamuza buskamuza merged commit 4a61569 into magento-engcom:libs-upgrade Apr 6, 2018
buskamuza added a commit that referenced this pull request Apr 6, 2018
Update `zendframework/zend-code`
magento-engcom-team added a commit that referenced this pull request Jul 19, 2018


 - Merge Pull Request magento/graphql-ce#101 from magento/graphql-ce:category-fragment-fix
 - Merged commits:
   1. 284f345
   2. 6c8f256
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants