Skip to content

Update media gallery data provider to utilize collection processor and migrate current filters/joins #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrieldagama opened this issue Jun 12, 2020 · 1 comment · Fixed by #1473
Assignees
Labels
Backend Priority: P1 Needs to be fixed before any other issues
Milestone

Comments

@gabrieldagama
Copy link
Contributor

gabrieldagama commented Jun 12, 2020

Story #1291

In order for the filters to be extensible, we will have to implement the collection processor and migrate the current filter and joins.

Implementation details

  • Add virtual types for the collection processors (filter, sorting, pagination, join)
  • Add collection factory and collection processor to the MediaGalleryUi/Model/Listing/DataProvider.php and remove the SelectModifierInterface.
  • Migrate the IsLicensed (AdobeStockImageAdminUi/Model/FilterParametersProvider/IsLicensed.php) to a custom join using join processor
  • Migrate the Directory (MediaGalleryUi/Model/FilterParametersProvider/Directory.php) to a custom filter using filter processor
  • Migrate the KeywordsFilter (MediaGalleryUi/Ui/Component/DataProvider/KeywordFilter.php) to a custom filter using filter processor

Technical details
https://github.com/magento/adobe-stock-integration/wiki/MediaGalleryUi-DataProvider

@m2-assistant
Copy link

m2-assistant bot commented Jun 12, 2020

Hi @gabrieldagama. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@gabrieldagama gabrieldagama added this to the 2.1.0 milestone Jun 12, 2020
@sivaschenko sivaschenko added Priority: P1 Needs to be fixed before any other issues Backend labels Jun 12, 2020
@Nazar65 Nazar65 self-assigned this Jun 15, 2020
@Nazar65 Nazar65 removed their assignment Jun 15, 2020
@gabrieldagama gabrieldagama self-assigned this Jun 15, 2020
gabrieldagama pushed a commit that referenced this issue Jun 17, 2020
#1456 - Removed SelectModifierInterface and added CollectionProcessor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Priority: P1 Needs to be fixed before any other issues
Projects
None yet
3 participants