#1456 - Removed SelectModifierInterface and added CollectionProcessor #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@magento run all tests |
sivaschenko
requested changes
Jun 15, 2020
There was a problem hiding this comment.
Thanks for the PR @gabrieldagama , please see my review comments
| @@ -33,11 +33,11 @@ | |||
| </argument> | |||
| </arguments> | |||
| </type> | |||
| <type name="Magento\MediaGalleryUi\Model\SelectModifierComposite"> | |||
| <virtualType name="Magento\MediaGalleryUi\Model\Api\SearchCriteria\CollectionProcessor\JoinProcessor" type="Magento\Framework\Api\SearchCriteria\CollectionProcessor\JoinProcessor"> | |||
There was a problem hiding this comment.
This virtual type is already declared in MediaGalleryUi module, so I think there is no need to specify the type
Suggested change
| <virtualType name="Magento\MediaGalleryUi\Model\Api\SearchCriteria\CollectionProcessor\JoinProcessor" type="Magento\Framework\Api\SearchCriteria\CollectionProcessor\JoinProcessor"> | |
| <virtualType name="Magento\MediaGalleryUi\Model\Api\SearchCriteria\CollectionProcessor\JoinProcessor"> |
| @@ -73,7 +83,6 @@ public function getData(): array | |||
| try { | |||
| /** @var SearchResult $searchResult */ | |||
| $searchResult = $this->getSearchResult(); | |||
| $this->selectModifier->apply($searchResult->getSelect(), $this->getSearchCriteria()); | |||
|
|
|||
| return $this->searchResultToOutput($searchResult); | |||
There was a problem hiding this comment.
Unnecessary variable can be eliminated
Suggested change
| return $this->searchResultToOutput($searchResult); | |
| return $this->searchResultToOutput($this->getSearchResult()); |
| 'keywords_table.keyword_id = asset_keywords_table.id', | ||
| ['asset_id'] | ||
| ), | ||
| ->joinInner( |
There was a problem hiding this comment.
let's keep the consistent formatting in this method (let's move ) to the next line)
m2-community-project
bot
added
Progress: changes requested
Progress: acceptance testing
and removed
Progress: changes requested
labels
|
@magento run all tests |
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: acceptance testing
labels
sivaschenko
approved these changes
Jun 16, 2020
|
@magento run all tests |
m2-community-project
bot
added
Progress: acceptance testing
and removed
Progress: changes requested
labels
|
✔️ QA Passed Rechecked the:
|
m2-community-project
bot
added
Progress: ready for delivery
and removed
Progress: acceptance testing
labels
|
Hi @gabrieldagama, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Removed SelectModifierInterface and added CollectionProcessor to the MediaGalleryUi DataProvider.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Content->Media Gallery