Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Add support for gift messages #7363

Closed
3 of 8 tasks
keharper opened this issue Jun 6, 2020 · 3 comments
Closed
3 of 8 tasks

GraphQL: Add support for gift messages #7363

keharper opened this issue Jun 6, 2020 · 3 comments
Labels
2.4.1 Major Update Significant original updates to existing content Partner: Atwix

Comments

@keharper
Copy link
Contributor

keharper commented Jun 6, 2020

Community engineering issue

Type of Doc:

  • New topic
  • Topic Update, Devdoc link: multiple
  • Other

Magento 2 GitHub Issue: magento/magento2#28519

Magento 2 GitHub PR: magento/magento2#28072

Magento 2 version:

  • 2.4.1

Notifications of Changes:

  • Changes to Admin interface?
  • New software requirements?
  • New REST endpoints or updated GraphQL query syntax?
  • New command line option?

Content

This issue provides an overview of the GraphQL documentation changes required to support gift messages. Additional work might be required.

  • Update the storeConfig query to include new fields
  • Potentially update any mutation that adds items to a cart or updates a cart
  • Potentially update the cart query

Important

  • If any affected file in the v2.4/graphql directory is a symlink, the symlink must be broken with the git rm <path to 2.4 file> command. Then copy the v2.3 version over to v2.4.

  • If any file in the _includes/graphql directory needs to be updated, and that file name does not end with -24.md, make a copy of that file and give it a name that ends with -24.md. All files in the v2.4 directory that reference the original include file must be updated to reference the new -24.md file.

It is not necessary to update all examples to show the gift message functionality. One example somewhere should suffice.

Create your branch off of 2.4.1-develop.

Additional information

This issue is assigned to Atwix, because they contributed the functionality.

@keharper keharper added Major Update Significant original updates to existing content Groomed Partner: Atwix 2.4.x Magento 2.4.x related changes labels Jun 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 6, 2020

Hi @keharper. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@keharper keharper added 2.4.1 and removed 2.4.x Magento 2.4.x related changes labels Jun 7, 2020
@atwixfirster
Copy link
Contributor

@magento I am working on this

@atwixfirster
Copy link
Contributor

atwixfirster commented Jun 24, 2020

Update the storeConfig query to include new fields

done

PR: #7449

Potentially update the cart query

done

PR: #7476

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.1 Major Update Significant original updates to existing content Partner: Atwix
Projects
None yet
Development

No branches or pull requests

3 participants