Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Add coverage for gift wrapping and messages #7745

Merged
merged 12 commits into from
Aug 19, 2020
Merged

GraphQL: Add coverage for gift wrapping and messages #7745

merged 12 commits into from
Aug 19, 2020

Conversation

keharper
Copy link
Contributor

@keharper keharper commented Aug 16, 2020 •
edited
Loading

Purpose of this pull request

This pull request (PR) adds the setGiftOptionsOnCart mutation and updates the output attributes for the storeConfig query, the Cart object, and others

Fixes #7365
Fixes #7363

Affected DevDocs pages

  • Many

Links to Magento source code

  • ...

whatsnew
Added the setGiftOptionsOnCart mutation to set gift messages, gift wrapping, gift receipts, and printed cards to an entire order. The updateCartItems mutation has been updated to allow adding a gift message or gift wrapping to individual products.

@keharper keharper added Internal Dev Differentiates work between community and Magento staff Community Docs impacted by community code contribution New Topic A major update published as an entirely new document 2.4.1 labels Aug 16, 2020
@keharper keharper self-assigned this Aug 16, 2020
@keharper keharper marked this pull request as draft August 16, 2020 02:33
rogyar
rogyar reviewed Aug 16, 2020
View reviewed changes
@keharper
Copy link
Contributor Author

I deliberately did not document the attributes added to the data types that implement the CartItemInterface in this PR. I need to create a new section in the left navigation of devdocs about interfaces and their implementations. I'll do that all at once in a separate PR.

@keharper keharper requested review from avattam06 and erikmarr August 19, 2020 17:23
@keharper keharper marked this pull request as ready for review August 19, 2020 17:24
erikmarr
erikmarr approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits/suggestions

avattam06
avattam06 reviewed Aug 19, 2020
View reviewed changes
@keharper
Copy link
Contributor Author

running tests

@keharper
Copy link
Contributor Author

running tests

@keharper keharper merged commit e0005c0 into 2.4.1-develop Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the kh_giftwrap branch August 22, 2020 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogyar rogyar rogyar left review comments

@avattam06 avattam06 avattam06 left review comments

@erikmarr erikmarr erikmarr approved these changes

Assignees

@rogyar rogyar

@keharper keharper

@avattam06 avattam06

@erikmarr erikmarr

Labels
2.4.1 Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keharper @rogyar @avattam06 @erikmarr