Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Adding a new topic of how to add a new dynamic rows system config #4528

Merged
merged 13 commits into from
May 21, 2019
Merged

Adding a new topic of how to add a new dynamic rows system config #4528

merged 13 commits into from
May 21, 2019

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented May 15, 2019 •
edited by dshevtsov
Loading

Purpose of this pull request

This pull request (PR) adds a new tutorial where it is described how to add a dynamic rows system config into Magento backend. Also provides a preview of the new added system config.

Affected DevDocs pages

whatsnew
Added a new tutorial that shows you how to add a dynamic rows system configuration.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-assigned this May 15, 2019
@jeff-matthews jeff-matthews added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document labels May 17, 2019
@jeff-matthews
Copy link
Contributor

I'm excited to see a new topic contribution @eduard13! Thank you! After @osrecio does a technical review, we'll do an editorial review.

osrecio
osrecio approved these changes May 19, 2019
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in my local environment following the documentation and works like a charm.

Thanks @eduard13 for do easy and understandable to anyone

@jeff-matthews jeff-matthews requested a review from shrielenee May 20, 2019 13:25
shrielenee
shrielenee suggested changes May 20, 2019
View reviewed changes
@shrielenee shrielenee added the Waiting for Response Waiting for response from internal/external parties label May 20, 2019
@eduard13
Copy link
Contributor Author

Hi @shrielenee, thank you for your review, could you please check the latest changes?
Thank you a lot.

shrielenee
shrielenee suggested changes May 20, 2019
View reviewed changes
Copy link
Contributor

@shrielenee shrielenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more changes!

@shrielenee
Copy link
Contributor

@eduard13 I have one more question about the way a path is rendering, as seen above in my comments. Please review and edit as necessary, then we should be ready to merge. 🙇‍♀

shrielenee
shrielenee suggested changes May 21, 2019
View reviewed changes
Copy link
Contributor

@shrielenee shrielenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about a path

@shrielenee shrielenee removed the Waiting for Response Waiting for response from internal/external parties label May 21, 2019
@shrielenee
Copy link
Contributor

running tests

@shrielenee
Copy link
Contributor

running tests

@shrielenee shrielenee merged commit 6e12e46 into magento:master May 21, 2019
@ghost
Copy link

ghost commented May 21, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@shrielenee
Copy link
Contributor

Great job @eduard13!

@eduard13
Copy link
Contributor Author

Thank you @shrielenee for your help.

@dshevtsov dshevtsov mentioned this pull request May 28, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@osrecio osrecio osrecio approved these changes

@shrielenee shrielenee shrielenee approved these changes

Assignees

@osrecio osrecio

Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eduard13 @devops-devdocs @jeff-matthews @shrielenee @osrecio @magento-engcom-team