This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Weekly digest #4620
Merged
Weekly digest #4620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshevtsov
added
Editorial
lorikrell
approved these changes
May 28, 2019
| type: Major update | ||
| date: May 23, 2019 | ||
| link: https://github.com/magento/devdocs/pull/4590 | ||
| - description: 'Reformatted YAML samples in the [Configure Environments: Services |
There was a problem hiding this comment.
Is this a random single quote around this sentence ' ', also period?
There was a problem hiding this comment.
The quote is added by the YAML generator. It is added when the string contains special symbols. YAML or :could be special in this case I guess.
The period has to be added to the original PR #4574.
_data/whats-new.yml
Outdated
| date: May 22, 2019 | ||
| link: https://github.com/magento/devdocs/pull/4574 | ||
| - description: Added a [new tutorial](https://devdocs.magento.com/guides/v2.3/ext-best-practices/tutorials/dynamic-row-system-config.html) | ||
| that shows you how to add a dynamic rows system configuration |
There was a problem hiding this comment.
Just a period
Suggested change
| that shows you how to add a dynamic rows system configuration | |
| that shows you how to add a dynamic rows system configuration. |
There was a problem hiding this comment.
The period has to be added into whatsnew at the original PR #4528.
shrielenee
approved these changes
May 28, 2019
|
running tests |
|
Hi @dshevtsov, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request is a weekly digest update.
Affected DevDocs pages