Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Small changes #4799

Merged
merged 27 commits into from
Jun 21, 2019
Merged

Small changes #4799

merged 27 commits into from
Jun 21, 2019

Conversation

Jakob Meissner and others added 27 commits May 2, 2019 12:41
Custom step is hidden when using back button
For Alert widget, Add __('<your_string>') method in Example because this method is used for translation of the string.
Add __('<your_string>') method in Alert Widget
Fix description of theme.xml contents
Fixed up formatting errors in 'Applying patches' topic.
The Magento website (https://devdocs.magento.com/guides/v2.3/config-guide/cli/config-cli-subcommands-mode.html) renders the <magento_root> tags as html, so they are not visible to the reader.
Fix root to be visible on Magento DevDocs website
Add __('<your_string>') method in Confirm Widget Example
Update docs about composer-packaged themes to include naming convention
Add content related to loader widget
Add __('<your_string>') method in Confirm Widget Examples
@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.

✅ hardikm-cirkleinc
✅ dobooth
✅ DrewML
✅ twocs
✅ ParthBrahmbhatt
✅ jeff-matthews
❌ jaykobi

@jeff-matthews jeff-matthews self-assigned this Jun 21, 2019
@jeff-matthews jeff-matthews added the Internal Dev Differentiates work between community and Magento staff label Jun 21, 2019
@jeff-matthews
Copy link
Contributor Author

running tests

@jeff-matthews jeff-matthews merged commit 2619038 into master Jun 21, 2019
@ghost
Copy link

ghost commented Jun 21, 2019

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants