This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom step is hidden when using back button
For Alert widget, Add __('<your_string>') method in Example because this method is used for translation of the string.
Add __('<your_string>') method in Alert Widget
Fix description of theme.xml contents
Fixed up formatting errors in 'Applying patches' topic.
Update checkout_new_step.md
The Magento website (https://devdocs.magento.com/guides/v2.3/config-guide/cli/config-cli-subcommands-mode.html) renders the <magento_root> tags as html, so they are not visible to the reader.
Fix root to be visible on Magento DevDocs website
Co-Authored-By: Jeff Matthews <[email protected]>
Add __('<your_string>') method in Confirm Widget Example
Update docs about composer-packaged themes to include naming convention
Add content related to loader widget
Add __('<your_string>') method in Confirm Widget Examples
|
keharper
approved these changes
Jun 21, 2019
running tests |
Hi @jeff-matthews, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request