Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add __('<your_string>') method in Alert Widget - #4759

Merged
dobooth merged 2 commits into
magento:small_changesfrom
magehardik:patch-4
Jun 17, 2019
Merged

dobooth merged 2 commits into
magento:small_changesfrom
magehardik:patch-4

Conversation

For Alert widget, Add __('<your_string>') method in Example because this method is used for translation of the string.
@devops-devdocs

Copy link
Copy Markdown
Collaborator

An admin must run tests on this PR before it can be merged.

@dobooth

dobooth commented Jun 14, 2019

Copy link
Copy Markdown
Contributor

Already took your first version: #4745

@dobooth dobooth closed this Jun 14, 2019
@ghost

ghost commented Jun 14, 2019

Copy link
Copy Markdown

Hi @hardikm-cirkleinc, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth reopened this Jun 14, 2019
@dobooth

dobooth commented Jun 14, 2019

Copy link
Copy Markdown
Contributor

Sorry! Different widget.
In the future, you can bundle these similar changes into a single PR.

@dobooth dobooth self-assigned this Jun 14, 2019
@dobooth
dobooth changed the base branch from master to small_changes June 17, 2019 14:07
@dobooth
dobooth merged commit 21049b7 into magento:small_changes Jun 17, 2019
@ghost

ghost commented Jun 17, 2019

Copy link
Copy Markdown

Hi @hardikm-cirkleinc, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jeff-matthews jeff-matthews mentioned this pull request Jun 21, 2019
@dobooth dobooth mentioned this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants