This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Small changes #4872
Merged
Small changes #4872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dobooth
commented
Jun 28, 2019
dobooth
commented
- Fixed #4622 /guides/v2.3/install-gde/prereq/install-rabbitmq.html and v2.2 #4866
- Add Marketplace link to Upcoming releases page. #4867
- [ImgBot] Optimize images #4815
- Clarify module dependency rule wording #4826
- SemVer is not used #4729
- Recommend including gender as a translation variable #4805
- Changed OVE to OVER ( it was confusing ) #4856
- Fix PR owner #4841
- link tag can be use to insert CSS file #4848
- GitHub issue #4505: Fix table formatting and link issues #4834
- fixing code issue #4842
- Update theme-best-practice.md #4845
- Adding the missing menu item for the DynamicRows topic #4808
- Added note for developer mode #4830
- Add __('<your_string>') method in Confirm Widget Examples #4797
- Add content related to loader widget #4790
- Update docs about composer-packaged themes to include naming convention #4777
- Fix root to be visible on Magento DevDocs website #4779
- Update checkout_new_step.md #4399
- Fixed up formatting errors in 'Applying patches' topic. #4772
- Feedback on page: /guides/v2.3/config-guide/cli/config-cli-subcommands-mode.html (update git rm instruction) #4748
- Add __('<your_string>') method in Alert Widget #4759
Custom step is hidden when using back button
As mentioned under Minor it can include breaking changes, which as per SemVer should make it a Major release.
For Alert widget, Add __('<your_string>') method in Example because this method is used for translation of the string.
Add __('<your_string>') method in Alert Widget
Fix description of theme.xml contents
Fixed up formatting errors in 'Applying patches' topic.
Update checkout_new_step.md
The Magento website (https://devdocs.magento.com/guides/v2.3/config-guide/cli/config-cli-subcommands-mode.html) renders the <magento_root> tags as html, so they are not visible to the reader.
Fix root to be visible on Magento DevDocs website
Co-Authored-By: Jeff Matthews <[email protected]>
Add __('<your_string>') method in Confirm Widget Example
Update docs about composer-packaged themes to include naming convention
Add content related to loader widget
Add __('<your_string>') method in Confirm Widget Examples
In line with magento2/architecture#170
SemVer is not used
Added Marketplace link for Amazon Sales Channel.
Clarify module dependency rule wording
[ImgBot] Optimize images
Add Marketplace link to Upcoming releases page.
Fixed #4622 /guides/v2.3/install-gde/prereq/install-rabbitmq.html and v2.2
|
|
|
@dobooth unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
bdenham
approved these changes
Jun 28, 2019
Co-Authored-By: Bruce Denham <[email protected]>
|
running tests |
|
Hi @dobooth, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.