Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Clarify module dependency rule wording #4826

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Conversation

scottsb
Copy link
Member

@scottsb scottsb commented Jun 24, 2019

Purpose of this pull request

This pull request (PR) clarifies the backwards compatibility rule about adding new dependencies between Magento modules. Previously I had trouble understanding what it was saying.

See for further context:
https://magentocommeng.slack.com/archives/CBSL1DF8B/p1561217992212100

Affected DevDocs pages

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 24, 2019

CLA assistant check
All committers have signed the CLA.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@buskamuza buskamuza requested a review from akaplya June 24, 2019 21:28
@osrecio osrecio self-assigned this Jun 26, 2019
@erikmarr erikmarr self-requested a review June 26, 2019 14:08
@erikmarr erikmarr added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes small changes Technical Updates to the code or processes that alter the technical content of the doc Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies and removed Technical Updates to the code or processes that alter the technical content of the doc labels Jun 26, 2019
@dobooth dobooth changed the base branch from master to small_changes June 28, 2019 14:08
@dobooth dobooth merged commit ae4797f into magento:small_changes Jun 28, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

Hi @scottsb, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth mentioned this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants