This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Added example of mixin for jQuery Widget #5229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2019 15:46
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
added
2.2.x
2.3.x
|
Hi @serhiyzhovnir. Thank you for the great examples! |
rogyar
approved these changes
Aug 21, 2019
jeff-matthews
suggested changes
Aug 23, 2019
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
jeff-matthews
removed
the
Technical
|
Hi @jeff-matthews |
jeff-matthews
suggested changes
Aug 23, 2019
There was a problem hiding this comment.
Thanks @serhiyzhovnir. I checked your branch locally and discovered some markdown linting errors similar to #5230. Our test system runs rake test:cicd, which now includes markdown linting in addition to link checking.
Please fix the following issues:
guides/v2.2/javascript-dev-guide/javascript/js_mixins.md:86: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/javascript/js_mixins.md:86: MD009 Trailing spaces
A detailed description of the rules is available at http://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
|
Hi @jeff-matthews |
m2-community-project
bot
added
Progress: acceptance testing
and removed
Progress: changes requested
labels
jeff-matthews
approved these changes
Aug 26, 2019
|
running tests |
|
Hi @serhiyzhovnir, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds an example of adding a mixin for jQuery widget.
Affected DevDocs pages
Links to Magento source code
whatsnew
Added new code examples to the JavaScript Mixins topic.