This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Fixed ordered list prefix (MD029) - Group 10 #5681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keharper
suggested changes
Oct 14, 2019
There was a problem hiding this comment.
Approved, pending one nit-picky change.
Also, the topic guides/v2.2/config-guide/cron/custom-cron-tut.md needs to be refactored or reconsidered. It contains references to the magento2-samples repo, which was abandoned ages ago. That's way outside the scope of this PR--just something to add to the backlog.
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
keharper
approved these changes
Oct 14, 2019
|
Hi @jeff-matthews, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) fixes some MD029 errors in the following guides:
The MD029 rule requires all ordered list prefixes to be consistent. We've chosen "one" as our prefix. The scope of #5248 also permits—but does not require—resolving errors related to the following rules:
This is one of three PRs related to #5248.