This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Markdown linting: Enable rule MD029 #5698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed ordered list prefix (MD029) - Group 1
Fixed ordered list prefix (MD029) - Group 2
Fixed ordered list prefix (MD029) - Group 3
Fixed ordered list prefix (MD029) - Group 5
Fixed ordered list prefix (MD029) - Group 4
Fixed ordered list prefix (MD029) - Group 6
Fixed ordered list prefix (MD029) - Group 7
Fixed ordered list prefix (MD029) - Group 8
Fixed ordered list prefix (MD029) - Group 9
Fixed ordered list prefix (MD029) - Group 11
Fixed ordered list prefix (MD029) - Group 10
Fixed ordered list prefix (MD029) - Group 13
Fixed ordered list prefix (MD029) - Group 16
Fixed ordered list prefix (MD029) - Group 12
Fixed ordered list prefix (MD029) - Group 14
Fixed ordered list prefix (MD029) - Group 15
jeff-matthews
added
the
Editorial
dshevtsov
approved these changes
Oct 15, 2019
|
running tests |
|
Hi @jeff-matthews, thank you for your contribution! |
keharper
pushed a commit
that referenced
this pull request
Oct 17, 2019
* Resolved issue #5179 * Update guides/v2.2/frontend-dev-guide/themes/theme-create.md Co-Authored-By: hguthrie <[email protected]> * Update guides/v2.2/frontend-dev-guide/themes/theme-create.md Co-Authored-By: hguthrie <[email protected]> * Update guides/v2.3/frontend-dev-guide/themes/theme-create.md Co-Authored-By: hguthrie <[email protected]> * Update guides/v2.3/frontend-dev-guide/themes/theme-create.md Co-Authored-By: hguthrie <[email protected]> * Update identity-class.md * Import the correct `Magento\Framework\GraphQl\Query\Resolver\IdentityInterface`. * Clarify what is required and what is an implementation detail. * magento/devdocs#: Add a custom payment method to checkout. Fix Step 4 https://devdocs.magento.com/guides/v2.2/howdoi/checkout/checkout_payment.html https://devdocs.magento.com/guides/v2.3/howdoi/checkout/checkout_payment.html * Fixed infobox * Getting infobox correct * Trying to fix infobox * More finessing. * Debugging * Pipe in command was breaking infobox formatting * Escaped pipe in command * Pipe in command broke formatting. * Removed pipes from command * Trailing space. * trailing space * trailing space * MAGETWO-49336: Publication of breaking changes * Update BICs for 2.2.10 Convert included files to Markdown Add includes to the topic * Fix heading id * MAGETWO-49336: Publication of breaking changes * Update BICs for 2.3.3 Convert included files to Markdown Add the includes to main topic * Fix links (#5690) * fix links add parans * remove duplicate topic * add symlink * remove duplicate projects topic * create symlink * found another problem with a link * magento/devdocs#: Fix links in How Magento implements indexing (#5656) https://devdocs.magento.com/guides/v2.2/extension-dev-guide/indexing.html https://devdocs.magento.com/guides/v2.3/extension-dev-guide/indexing.html * added link to devblog post andfixed broken links in include files * magento/devdocs#: Describes changeCustomerPassword mutation errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/change-customer-password.html * Markdown linting: Enable rule MD029 (#5698) * Fixed errors in rest, test, and ui comps * Fix errors in release notes * Fixed errors in pattern-library and payment integrations * Fixed errors in marketplace, migration, mrg, and mtf * Fixed errors in install, js-dev, and inventory * Applied peer review edits * Applied peer review edits * Removed forced numbering class * Fixed errors in howdoi * Fixed errors in get-started, graphql * Fixed errors in frontend-dev-guide * Fixed errors in ext-dev * Fixed some errors in config * Fixed some errors in config * Applied edits from peer review * Removed redundant TOC * Fixed errors in config * Fixed errors in coding standards, comp-mgr, contributor * Disable rule * Fixed errors in _vidoes, reporting, arch * Fixed errors in includes (not cloud) * Enable rule * Fixed errors in cloud includes * Fixed errors in cloud * Added page-builder-types to gitignore file (#5708) * spaces of course * move categoryinterface out of category query (#5718) * Fix syntax for paths to run Actions on See https://help.github.com/en/articles/workflow-syntax-for-github-actions#example-including-paths
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) fixes all MD029 errors and enables the rule on production.
The MD029 rule requires all ordered list prefixes to be consistent. We've chosen "one" as our prefix. The scope of #5248 also permits—but does not require—resolving errors related to the following rules:
All changes in this PR have been introduced by previously reviewed and approved PRs:
This is the final PR to fix #5248.