This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Fixed cms query input #5920
Merged
Fixed cms query input #5920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An admin must run tests on this PR before it can be merged. |
keharper
approved these changes
Nov 4, 2019
m2-community-project
bot
added
Progress: review
Progress: approved
and removed
Progress: review
labels
keharper
added
2.3.x
rogyar
approved these changes
Nov 4, 2019
|
running tests |
|
Hi @shikhamis11, thank you for your contribution! |
|
Thanks @shikhamis11! |
keharper
added a commit
that referenced
this pull request
Nov 11, 2019
* Update the UI Date component documentation * Update xml-instructions.md Adding alternative magic method to retrieve arguments * Remove empty line * Adding changes to 2.2 too * Update adding-attributes.md Fix name of method to plug into and clarify return type notation. * Fix fenced code block language type * Use JavaScript for fenced code block language * Add newline before fenced code block I hope this will make the linter happy * Combine get method examples * Added translation methods in UI component templates * magento/devdocs#: Fix link on the “Magento payment provider gateway” page https://devdocs.magento.com/guides/v2.2/payments-integrations/payment-gateway/payment-gateway-intro.html https://devdocs.magento.com/guides/v2.3/payments-integrations/payment-gateway/payment-gateway-intro.html * Reorganized templates topic * Fixed symbolic link creation command * magento/devdocs#: Add revokeCustomerToken mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/revoke-customer-token.html * EQP updates (#5918) * set up EQP integration branch * Update api.md * Update auth.md * Update auth.md * Small formatting changes * Decapitalized headers * Small formatting changes * Update files.md * Grammar and formatting * Add new file filtering.md * Add filtering to the index * Fix broken link * Update packages.md * Update packages.md * Grammar and formatting * Editorial pass * Users.md (#5909) * Update users.md * Update users.md * Update users.md * Update users.md * Update users.md * Update users.md (#5915) * Update users.md * Update users.md * Update filters.md * linting corrections * add bogus file to resolve merge conflict * still resolving merge conflict * deleted file again * Revert "linting corrections" This reverts commit c84d489. * linting errors * adding file again * delete phantom file * Apply suggestions from code review Incorporating review comments. The line breaks are permitted, as developers may have IDE settings that are different than settings a writer typically uses. Co-Authored-By: Jeff Matthews <[email protected]> * Fixed cms query input (#5920) * Grammar and formatting * magento/devdocs#: Add createEmptyCart mutation API errors (#5881) - https://devdocs.magento.com/guides/v2.3/graphql/mutations/create-empty-cart.html * Replace jquery/ui usages with individual jQuery UI components (#5923) * Replace jquery/ui usages with individual jQuery UI components * Update custom_js.md * Update js_practice.md * Update custom_js.md Correcting linting error * Updated what's new (#5922) * Updated what's new * Apply suggestions from code review * Added guidance for fixing session start (#5877) * Added guidance for fixing session start failures when launching Magento cloud Docker on Windows environment * Fixed note indentation * Restored substep formatting * Add attributes to ProductFilterInput * Added attribution for contributor * Update the documentation for ActionDelete UI component documentation * Removed space * Changed subheadings hierarchy level * magento/devdocs#: Add addConfigurableProductsToCart mutation API errors https://devdocs.magento.com/guides/v2.3/graphql/mutations/add-configurable-products.html * Update ActionsColumns UI component * Update Bookmarks UI component documentation * magento/devdocs#: Add addVirtualProductsToCart mutation API errors https://devdocs.magento.com/guides/v2.3/graphql/mutations/add-virtual-products.html * Update ColumnsControls UI component documentation * Adjusted the ActionsColumns component documentation * Adjusted the ui bookmarks UI component documentation * Fixed Examples title * Fixed Examples title * Fixed Examples title * Adjusted the ActionDelete component documentation * Grammar and formatting * Small update * magento/devdocs#: Add addSimpleProductsToCart mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/add-simple-products.html * Update Search UI component documentation * Fixed grammar * Added instructions for Fastly Edge Modules: Reroute to other CMS backend (#5865) * Added instructions for using Fastly Edge Modules to reroute requests to another backend * Updated based on review feedback - Changed title - Added separate "Prerequisites" section - Cleaned up introduction and configuration procedure * Updated manage message queues instructions (#5867) - Inserted Manage message queues instructions to enable bulk API message processing - Added prerequisite for RabbitMQ install - Removed confusing statement about managing message queues using cron jobs - Added note and link about configuring consumers_runner job on Cloud Changed _Start consumers_ topic title to _Start message queue consumers_ for consistency with v2.3 - Removed unneeded link reference * Small grammar change * Small grammar fix * Small grammar change * Update add-virtual-products.md Edited for grammar. * Update add-simple-products.md Grammatical changes * Update add-configurable-products.md Grammatical edits * Update revoke-customer-token.md * Small grammar update * magento/devdocs#: Add addVirtualProductsToCart mutation API errors * Enhance Commerce release info (#5953) * Added security patches * Removed shipping * Editorial changes * Added disclaimer * Removed PWA qualification * Removed shipping from compatibility table * Removed Page Builder * Markdown linting: Enable rule MD032 (lists should be surrounded by blank lines) (#5957) * Fixed all obvious errors * Fixed false positives * Fix endpoint domain names * Update MFTF datafile. * Update migration-troubleshooting.md Fix error in XML, ignore field should be added to <field_rules> node * Fix the mdl version to 0.7.0 in the GH workflow * magento/devdocs#: Add createCustomer mutation API errors (#5961) * magento/devdocs#: Add createCustomer mutation API errors https://devdocs.magento.com/guides/v2.3/graphql/mutations/create-customer.html * Update create-customer.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Summary
In Cms Page query example input is incorrect . The
identifiershould be stringAffected DevDocs pages
https://devdocs.magento.com/guides/v2.3/graphql/queries/cms-page.html