-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
_data/whats-new.yml
Outdated
type: New topic | ||
date: October 29, 2019 | ||
link: https://github.com/magento/devdocs/pull/5874 | ||
- description: Added the following information to the [Elasticsearch set up](https://devdocs.magento.com/guides/v2.3/cloud/project/project-conf-files_services-elastic.html)<br/>topic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this "set up" or "setup"? Seems like it might be one word.
type: Technical changes | ||
date: October 22, 2019 | ||
link: https://github.com/magento/devdocs/pull/5721 | ||
- description: Added the documentation for the [DynamicRowsRecord](https://devdocs.magento.com/guides/v2.2/ui_comp_guide/components/ui-dynamicrows-record.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should DynamicRowsRecord be in code formatting?
type: New topic | ||
date: October 16, 2019 | ||
link: https://github.com/magento/devdocs/pull/5718 | ||
- description: Added an "Errors" section to the [changeCustomerPassword mutation](https://devdocs.magento.com/guides/v2.3/graphql/mutations/change-customer-password.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure you reference doc sections in other line items in quotes... check for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also consistency in ending punctuation.
type: Major update | ||
date: October 14, 2019 | ||
link: https://github.com/magento/devdocs/pull/5686 | ||
- description: Added a warning to ensure that the [CRYPT_KEY](https://devdocs.magento.com/guides/v2.3/cloud/env/variables-deploy.html#crypt_key) deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRYPT_KEY in code format?
_data/whats-new.yml
Outdated
type: New topic | ||
date: October 10, 2019 | ||
link: https://github.com/magento/devdocs/pull/5642 | ||
- description: Amazon Sales Channel version 3.0.0 is available in the [Marketplace](https://marketplace.magento.com/magento-module-amazon.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem like an action statement? Like "Added release notes for the Amazon Sales Channel version 3.0.0, which is now available in the Marketplace" or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved --- Just had some questions/comments.
running tests |
Hi @meker12, thank you for your contribution! |
* Update the UI Date component documentation * Update xml-instructions.md Adding alternative magic method to retrieve arguments * Remove empty line * Adding changes to 2.2 too * Update adding-attributes.md Fix name of method to plug into and clarify return type notation. * Fix fenced code block language type * Use JavaScript for fenced code block language * Add newline before fenced code block I hope this will make the linter happy * Combine get method examples * Added translation methods in UI component templates * magento/devdocs#: Fix link on the “Magento payment provider gateway” page https://devdocs.magento.com/guides/v2.2/payments-integrations/payment-gateway/payment-gateway-intro.html https://devdocs.magento.com/guides/v2.3/payments-integrations/payment-gateway/payment-gateway-intro.html * Reorganized templates topic * Fixed symbolic link creation command * magento/devdocs#: Add revokeCustomerToken mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/revoke-customer-token.html * EQP updates (#5918) * set up EQP integration branch * Update api.md * Update auth.md * Update auth.md * Small formatting changes * Decapitalized headers * Small formatting changes * Update files.md * Grammar and formatting * Add new file filtering.md * Add filtering to the index * Fix broken link * Update packages.md * Update packages.md * Grammar and formatting * Editorial pass * Users.md (#5909) * Update users.md * Update users.md * Update users.md * Update users.md * Update users.md * Update users.md (#5915) * Update users.md * Update users.md * Update filters.md * linting corrections * add bogus file to resolve merge conflict * still resolving merge conflict * deleted file again * Revert "linting corrections" This reverts commit c84d489. * linting errors * adding file again * delete phantom file * Apply suggestions from code review Incorporating review comments. The line breaks are permitted, as developers may have IDE settings that are different than settings a writer typically uses. Co-Authored-By: Jeff Matthews <[email protected]> * Fixed cms query input (#5920) * Grammar and formatting * magento/devdocs#: Add createEmptyCart mutation API errors (#5881) - https://devdocs.magento.com/guides/v2.3/graphql/mutations/create-empty-cart.html * Replace jquery/ui usages with individual jQuery UI components (#5923) * Replace jquery/ui usages with individual jQuery UI components * Update custom_js.md * Update js_practice.md * Update custom_js.md Correcting linting error * Updated what's new (#5922) * Updated what's new * Apply suggestions from code review * Added guidance for fixing session start (#5877) * Added guidance for fixing session start failures when launching Magento cloud Docker on Windows environment * Fixed note indentation * Restored substep formatting * Add attributes to ProductFilterInput * Added attribution for contributor * Update the documentation for ActionDelete UI component documentation * Removed space * Changed subheadings hierarchy level * magento/devdocs#: Add addConfigurableProductsToCart mutation API errors https://devdocs.magento.com/guides/v2.3/graphql/mutations/add-configurable-products.html * Update ActionsColumns UI component * Update Bookmarks UI component documentation * magento/devdocs#: Add addVirtualProductsToCart mutation API errors https://devdocs.magento.com/guides/v2.3/graphql/mutations/add-virtual-products.html * Update ColumnsControls UI component documentation * Adjusted the ActionsColumns component documentation * Adjusted the ui bookmarks UI component documentation * Fixed Examples title * Fixed Examples title * Fixed Examples title * Adjusted the ActionDelete component documentation * Grammar and formatting * Small update * magento/devdocs#: Add addSimpleProductsToCart mutation API errors - https://devdocs.magento.com/guides/v2.3/graphql/mutations/add-simple-products.html * Update Search UI component documentation * Fixed grammar * Added instructions for Fastly Edge Modules: Reroute to other CMS backend (#5865) * Added instructions for using Fastly Edge Modules to reroute requests to another backend * Updated based on review feedback - Changed title - Added separate "Prerequisites" section - Cleaned up introduction and configuration procedure * Updated manage message queues instructions (#5867) - Inserted Manage message queues instructions to enable bulk API message processing - Added prerequisite for RabbitMQ install - Removed confusing statement about managing message queues using cron jobs - Added note and link about configuring consumers_runner job on Cloud Changed _Start consumers_ topic title to _Start message queue consumers_ for consistency with v2.3 - Removed unneeded link reference * Small grammar change * Small grammar fix * Small grammar change * Update add-virtual-products.md Edited for grammar. * Update add-simple-products.md Grammatical changes * Update add-configurable-products.md Grammatical edits * Update revoke-customer-token.md * Small grammar update * magento/devdocs#: Add addVirtualProductsToCart mutation API errors * Enhance Commerce release info (#5953) * Added security patches * Removed shipping * Editorial changes * Added disclaimer * Removed PWA qualification * Removed shipping from compatibility table * Removed Page Builder * Markdown linting: Enable rule MD032 (lists should be surrounded by blank lines) (#5957) * Fixed all obvious errors * Fixed false positives * Fix endpoint domain names * Update MFTF datafile. * Update migration-troubleshooting.md Fix error in XML, ignore field should be added to <field_rules> node * Fix the mdl version to 0.7.0 in the GH workflow * magento/devdocs#: Add createCustomer mutation API errors (#5961) * magento/devdocs#: Add createCustomer mutation API errors https://devdocs.magento.com/guides/v2.3/graphql/mutations/create-customer.html * Update create-customer.md
Purpose of this pull request
Updates the What's New topic with the latest changes.
Affected DevDocs pages