This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added an additional method regarding adding a SSH key #8379
Merged
meker12
merged 4 commits into
magento:mae-updates-to-ssh-key-enablement
from
sathiyaaa:issue-8372-added-a-method-of-adding-a-ssh-key
Dec 18, 2020
Merged
Added an additional method regarding adding a SSH key #8379
meker12
merged 4 commits into
magento:mae-updates-to-ssh-key-enablement
from
sathiyaaa:issue-8372-added-a-method-of-adding-a-ssh-key
Dec 18, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarnyShergold
suggested changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition - never realised this wasn't in the docs!
Co-authored-by: Barny Shergold <[email protected]>
BarnyShergold
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant!
Hi @sathiyaaa, thank you for your contribution! |
meker12
added a commit
that referenced
this pull request
Jan 4, 2021
* Added an additional method regarding adding a SSH key (#8379) * Added an additional method regarding adding a SSH key * Apply suggestions from code review Co-authored-by: Barny Shergold <[email protected]> * Updates based on review feedback - Replaced test SSH connection through GitHub instructions with link to GitHub documentation - Editorial revision and clean up Co-authored-by: Sathiya Prakash <[email protected]> Co-authored-by: Barny Shergold <[email protected]>
meker12
added a commit
that referenced
this pull request
Jan 4, 2021
* Updates based on review feedback - Replaced instructions for testing ssh connection with link to GitHub documentation - Editorial cleanup * Updates to ssh key enablement for Cloud projects (#8416) * Added an additional method regarding adding a SSH key (#8379) * Added an additional method regarding adding a SSH key * Apply suggestions from code review Co-authored-by: Barny Shergold <[email protected]> * Updates based on review feedback - Replaced test SSH connection through GitHub instructions with link to GitHub documentation - Editorial revision and clean up Co-authored-by: Sathiya Prakash <[email protected]> Co-authored-by: Barny Shergold <[email protected]> Co-authored-by: Sathiya Prakash <[email protected]> Co-authored-by: Barny Shergold <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2.x
Partner: EY
partners-contribution
PR created by Magento partner
Progress: done
Technical
Updates to the code or processes that alter the technical content of the doc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) fixes #8372
Affected DevDocs pages