Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

sathiyaaa
Copy link
Contributor

@sathiyaaa sathiyaaa commented Dec 14, 2020

Purpose of this pull request

This pull request (PR) fixes #8372

Affected DevDocs pages

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition - never realised this wasn't in the docs!

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@meker12 meker12 changed the base branch from master to mae-updates-to-ssh-key-enablement December 18, 2020 18:13
@meker12 meker12 merged commit a7e877b into magento:mae-updates-to-ssh-key-enablement Dec 18, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

Hi @sathiyaaa, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

meker12 added a commit that referenced this pull request Jan 4, 2021
* Added an additional method regarding adding a SSH key (#8379)

* Added an additional method regarding adding a SSH key

* Apply suggestions from code review

Co-authored-by: Barny Shergold <[email protected]>

* Updates based on review feedback

- Replaced test SSH connection through GitHub instructions
with link to GitHub documentation
- Editorial revision and clean up

Co-authored-by: Sathiya Prakash <[email protected]>
Co-authored-by: Barny Shergold <[email protected]>
meker12 added a commit that referenced this pull request Jan 4, 2021
* Updates based on review feedback

- Replaced instructions for testing ssh connection
with link to GitHub documentation
- Editorial cleanup

* Updates to ssh key enablement for Cloud projects (#8416)

* Added an additional method regarding adding a SSH key (#8379)

* Added an additional method regarding adding a SSH key

* Apply suggestions from code review

Co-authored-by: Barny Shergold <[email protected]>

* Updates based on review feedback

- Replaced test SSH connection through GitHub instructions
with link to GitHub documentation
- Editorial revision and clean up

Co-authored-by: Sathiya Prakash <[email protected]>
Co-authored-by: Barny Shergold <[email protected]>

Co-authored-by: Sathiya Prakash <[email protected]>
Co-authored-by: Barny Shergold <[email protected]>
@hguthrie hguthrie added 2.x Technical Updates to the code or processes that alter the technical content of the doc labels Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Partner: EY partners-contribution PR created by Magento partner Progress: done Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback on page: /cloud/before/before-workspace-ssh.html
5 participants