This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Updates to ssh key enablement for Cloud projects #8416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added an additional method regarding adding a SSH key * Apply suggestions from code review Co-authored-by: Barny Shergold <[email protected]>
meker12
added
2.x
Technical
hguthrie
suggested changes
Dec 18, 2020
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
Yes-- I merged the other PR to the SSH enablement topic. Just working on merging this into integration branch to fix it up. |
meker12
changed the base branch from
master
to
mae-ssh-enablement-improvements
- Replaced test SSH connection through GitHub instructions with link to GitHub documentation - Editorial revision and clean up
hguthrie
approved these changes
Dec 23, 2020
| @@ -38,23 +38,9 @@ If the directory does not exist or has no SSH key files, you must generate at le | |||
|
|
|||
| If you have at least one SSH key in your directory, add the key to your Magento and GitHub accounts: | |||
|
|
|||
| - [Add an SSH key to your GitHub account](https://help.github.com/articles/adding-a-new-ssh-key-to-your-github-account/) | |||
| - [Add an SSH key to your GitHub account](https://help.github.com/articles/adding-a-new-ssh-key-to-your-github-account/) and [test the SSH connection](https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/testing-your-ssh-connection). | |||
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
|
Hi @meker12, thank you for your contribution! |
meker12
added a commit
that referenced
this pull request
Jan 4, 2021
* Updates based on review feedback - Replaced instructions for testing ssh connection with link to GitHub documentation - Editorial cleanup * Updates to ssh key enablement for Cloud projects (#8416) * Added an additional method regarding adding a SSH key (#8379) * Added an additional method regarding adding a SSH key * Apply suggestions from code review Co-authored-by: Barny Shergold <[email protected]> * Updates based on review feedback - Replaced test SSH connection through GitHub instructions with link to GitHub documentation - Editorial revision and clean up Co-authored-by: Sathiya Prakash <[email protected]> Co-authored-by: Barny Shergold <[email protected]> Co-authored-by: Sathiya Prakash <[email protected]> Co-authored-by: Barny Shergold <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Add additional method to add and update SSH keys. Merges changes introduced in #8379.
Affected DevDocs pages