This repository was archived by the owner on Dec 19, 2019. It is now read-only.
Correct SendFriend Visibility Check #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing check would return an error if sending a product with search only visibility.
4 tasks
pmclain
commented
Jul 2, 2019
| $product->getVisibility(), | ||
| $this->visibility->getVisibleInCatalogIds() | ||
| (int) $product->getVisibility(), | ||
| $this->visibility->getVisibleInSiteIds(), |
There was a problem hiding this comment.
The docblock hint for this function's return value is incorrectly string[] proposed fix here magento/magento2#23532
TomashKhamlai
added
the
Progress: ready for qa
naydav
approved these changes
Jul 8, 2019
TomashKhamlai
removed
the
Progress: ready for qa
|
Hi @pmclain, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The existing check would return an error if sending a product with search only
visibility.
Manual testing scenarios (*)
Contribution checklist (*)