-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Correct array type hints in Visibility model #23532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct array type hints in Visibility model #23532
Conversation
The visibility consts returned the the arrays are `int` not `string`
Hi @pmclain. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @sivaschenko, thank you for the review.
|
✔️ QA passed |
Hi @pmclain, thank you for your contribution! |
…d-ms-tile-image-meta-tag * origin/2.3-develop: (3294 commits) magento#23427 Fix static magento#23532 Fix-static-tests magento/magento#23500 fix funk tests fix validation class for max-words MC-17922: Date in filter area doesn't match with Active filters bar Fixed coding standards violations Updated unit test MC-17922: Date in filter area doesn't match with Active filters bar Update Framework/Mail::Message to send all emails as MIME, not just HTML emails. MC-17922: Date in filter area doesn't match with Active filters bar Removed editors from all dependable customer billing address fields Correct array type hints Fix mass detection issue Testing configurable option update based on product and attribute_id move breakpoint by -1px to make nav work correctly at viweport width of 768px MC-17275: Admin Down after changing store domain/cookie Setting right shipper street1 in addressline1 MC-17275: Admin Down after changing store domain/cookie Replaced urldecode with rawurldecode that not converting + into space Fixed issue magento#23383 ...
…lk-delete * origin/2.3-develop: (4954 commits) magento#23427 Fix static magento#23532 Fix-static-tests magento/magento#23500 fix funk tests fix validation class for max-words MC-17922: Date in filter area doesn't match with Active filters bar Fixed coding standards violations Updated unit test MC-17922: Date in filter area doesn't match with Active filters bar Update Framework/Mail::Message to send all emails as MIME, not just HTML emails. MC-17922: Date in filter area doesn't match with Active filters bar Removed editors from all dependable customer billing address fields Correct array type hints Fix mass detection issue Testing configurable option update based on product and attribute_id move breakpoint by -1px to make nav work correctly at viweport width of 768px MC-17275: Admin Down after changing store domain/cookie Setting right shipper street1 in addressline1 MC-17275: Admin Down after changing store domain/cookie Replaced urldecode with rawurldecode that not converting + into space Fixed issue magento#23383 ...
Description (*)
The visibility consts returned the the arrays are
int
notstring
Manual testing scenarios (*)
Contribution checklist (*)