Correct array type hints in Visibility model #23532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visibility consts returned the the arrays are `int` not `string`
|
Hi @pmclain. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
added
Component: Catalog
Release Line: 2.3
Partner: Something Digital
partners-contribution
4 tasks
sivaschenko
approved these changes
Jul 2, 2019
|
Hi @sivaschenko, thank you for the review.
|
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
✔️ QA passed |
ghost
added
Progress: extended testing
Progress: accept
and removed
Progress: testing in progress
Progress: extended testing
labels
taskula
pushed a commit
to Hypernova-Oy/magento2
that referenced
this pull request
Jul 5, 2019
|
Hi @pmclain, thank you for your contribution! |
vasilii-b
pushed a commit
to vasilii-b/magento2
that referenced
this pull request
Jul 10, 2019
…d-ms-tile-image-meta-tag * origin/2.3-develop: (3294 commits) magento#23427 Fix static magento#23532 Fix-static-tests magento/magento#23500 fix funk tests fix validation class for max-words MC-17922: Date in filter area doesn't match with Active filters bar Fixed coding standards violations Updated unit test MC-17922: Date in filter area doesn't match with Active filters bar Update Framework/Mail::Message to send all emails as MIME, not just HTML emails. MC-17922: Date in filter area doesn't match with Active filters bar Removed editors from all dependable customer billing address fields Correct array type hints Fix mass detection issue Testing configurable option update based on product and attribute_id move breakpoint by -1px to make nav work correctly at viweport width of 768px MC-17275: Admin Down after changing store domain/cookie Setting right shipper street1 in addressline1 MC-17275: Admin Down after changing store domain/cookie Replaced urldecode with rawurldecode that not converting + into space Fixed issue magento#23383 ...
vasilii-b
pushed a commit
to vasilii-b/magento2
that referenced
this pull request
Jul 10, 2019
…lk-delete * origin/2.3-develop: (4954 commits) magento#23427 Fix static magento#23532 Fix-static-tests magento/magento#23500 fix funk tests fix validation class for max-words MC-17922: Date in filter area doesn't match with Active filters bar Fixed coding standards violations Updated unit test MC-17922: Date in filter area doesn't match with Active filters bar Update Framework/Mail::Message to send all emails as MIME, not just HTML emails. MC-17922: Date in filter area doesn't match with Active filters bar Removed editors from all dependable customer billing address fields Correct array type hints Fix mass detection issue Testing configurable option update based on product and attribute_id move breakpoint by -1px to make nav work correctly at viweport width of 768px MC-17275: Admin Down after changing store domain/cookie Setting right shipper street1 in addressline1 MC-17275: Admin Down after changing store domain/cookie Replaced urldecode with rawurldecode that not converting + into space Fixed issue magento#23383 ...
VladimirZaets
added
the
Auto-Tests: Not Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The visibility consts returned the the arrays are
intnotstringManual testing scenarios (*)
Contribution checklist (*)