Skip to content

[Enhancement] DiscouragedFunction rule improvement #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lenaorobei opened this issue Mar 19, 2019 · 0 comments · Fixed by #63
Closed

[Enhancement] DiscouragedFunction rule improvement #62

lenaorobei opened this issue Mar 19, 2019 · 0 comments · Fixed by #63
Assignees
Labels
enhancement Improvements to existing rules

Comments

@lenaorobei
Copy link
Contributor

lenaorobei commented Mar 19, 2019

Description

Magento2.PHP.DiscouragedFunction needs to be changed in order to cover different use-cases.

Expected behavior

The first part of the rule should cover following:

  • The use of insecure functions triggers 9 severity warning (applicable to all codebase).
    Examples of insecure functions: exec, md5, unserialize, assert.

The first part of the rule should cover following:

  • The use of discouraged functions triggers 8 severity warning (not applicable to */Test/* and */lib/*).
    Examples of discouraged functions: sizeof, print_r, ^socket_.*$, ^stream_.*$.
@lenaorobei lenaorobei added the enhancement Improvements to existing rules label Mar 19, 2019
@lenaorobei lenaorobei changed the title [Enhancement] [Enhancement] DiscouragedFunction rule improvement Mar 19, 2019
@lenaorobei lenaorobei self-assigned this Mar 19, 2019
magento-devops-reposync-svc pushed a commit that referenced this issue Sep 13, 2021
…-coding-standard-269

[Imported] AC-666: Copyright test for another extensions files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant