[Enhancement] DiscouragedFunction rule improvement #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paliarush
reviewed
Mar 19, 2019
| * | ||
| * @var boolean | ||
| */ | ||
| public $error = false; |
There was a problem hiding this comment.
Please validate the list against https://stackoverflow.com/questions/3115559/exploitable-php-functions and ask security team to review.
paliarush
reviewed
Mar 19, 2019
| * | ||
| * @var boolean | ||
| */ | ||
| public $error = false; |
There was a problem hiding this comment.
It's under Severity 9 warnings: Possible security and issues that may cause bugs. section.
We cannot reject extensions because of such functions right now. We will work iteratively to make rules stricter.
paliarush
approved these changes
Mar 19, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Sep 14, 2021
…oding-standard-270 [Imported] Fixed wrongly returning error for valid descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<exclude-pattern>*/Test/*</exclude-pattern>for rules, not applicable to tests and test files;