Fixed issue in line length sniff for phrase and __ keyword #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaorobei
requested changes
Aug 15, 2019
There was a problem hiding this comment.
Long time ago when this rule was introduced, the reason for it was that php bin/magento i18n:collect-phrases command couldn't work with concatenated strings. I just checked - now it can 🙂
So the fix here should be - remove this sniff code, from ruleset and unit test but add following to the ruleset in the alphabetical order to the <!-- Severity 6 warnings: Code style issues. --> section:
<rule ref="Generic.Files.LineLength">
<properties>
<property name="lineLimit" value="120"/>
<property name="absoluteLineLimit" value="0"/>
</properties>
<severity>6</severity>
<type>warning</type>
</rule>
…into 75_linelengthsniff_keyword # Conflicts: # Magento2/Tests/Files/LineLengthUnitTest.php
lenaorobei
previously approved these changes
Aug 16, 2019
…/__ keyword in string - fixed code style
- fixed readme
lenaorobei
approved these changes
Aug 16, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Nov 23, 2021
AC-1740: Add rectorphp as a dependency to magento-coding-standard and run it as part of the GitHub actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #75 : [BUG] LineLengthSniff RegEx misses long lines with Phrase/__ keyword in string