Skip to content

Changing Swatches to Drop-down does not remove swatches from existing products #11703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
expgabe opened this issue Oct 24, 2017 · 8 comments
Closed

Changing Swatches to Drop-down does not remove swatches from existing products #11703

expgabe opened this issue Oct 24, 2017 · 8 comments
Assignees
@eugene-shab
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@expgabe
Copy link

expgabe commented Oct 24, 2017

Preconditions

  1. Magento 2.2
  2. CentOS Cpanel 66.0 with Engintron Nginx for cpanel, Apache 2.4.28, MySQL 10.2.9-MariaDB , PHP 7.0

Steps to reproduce

  1. Login to Admin got to Stores -> Attributes
  2. Change Attribute's Catalog Input Type from Visual Swatch Swatches to Dropdown
  3. Clean cache
  4. Existing Configurable Products view does not change to Dropdown

Expected result

  1. All swatches should be removed and replaced with a drop down.

Actual result

  1. [Screenshot, logs]
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 24, 2017
@magento-engcom-team
Copy link
Contributor

@expgabe, thank you for your report.
We've created internal ticket(s) MAGETWO-82705 to track progress on the issue.

@adrzz
Copy link

adrzz commented Oct 30, 2017

Magento 2.2
Same error in new products.

@adrzz
Copy link

adrzz commented Oct 30, 2017

TEMP FIX

I replaced the code from module swatch (VIEW) with the drop-down file view.

Swatch file:
/vendor/magento/module-swatches/view/frontend/templates/product/view/renderer.phtml

Drop-down file:
module-configurable-product/view/frontend/templates/product/view/type/options/configurable.phtml

Steps to fix (TEMP)
Copy code from
module-configurable-product/view/frontend/templates/product/view/type/options/configurable.phtml

Paste and replace all code to file
/vendor/magento/module-swatches/view/frontend/templates/product/view/renderer.phtml

therool added a commit to therool/magento2 that referenced this issue Nov 14, 2017
@therool
Correctly provide list of swatch attributes for product magento#11703
15f6850
@therool therool mentioned this issue Nov 14, 2017
Closed
4 tasks
@eugene-shab
Copy link
Contributor

#mageconf

@eugene-shab eugene-shab self-assigned this Dec 15, 2017
@eugene-shab eugene-shab mentioned this issue Dec 15, 2017
Closed
@eugene-shab
Copy link
Contributor

eugene-shab commented Dec 15, 2017 •
edited
Loading

#mageconf

Closed because duplicate #12695

@eugene-shab eugene-shab mentioned this issue Dec 15, 2017
Merged
@sidolov
Copy link
Contributor

sidolov commented Jun 24, 2018

Hi @expgabe. Thank you for your report.
The issue has been fixed in #12771 by @eugene-shab in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@sidolov sidolov added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 24, 2018
@nmalevanec nmalevanec mentioned this issue Aug 22, 2018
Merged
@ishakhsuvarov
Copy link
Contributor

Hi @expgabe. Thank you for your report.
The issue has been fixed in #17750 by @nmalevanec in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@ishakhsuvarov ishakhsuvarov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 11, 2018
@enriquetarazona
Copy link

Applying those fixes removes the eav_attribute_option_swatch table but for ALL the swatch attributes. I just wanted to apply the dropdown change for one attribute but removed all the swatch attribute values as well. is there a fix for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugene-shab eugene-shab

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@eugene-shab @ishakhsuvarov @okorshenko @enriquetarazona @sidolov @expgabe @magento-engcom-team @adrzz