Skip to content

[Forwardport] Unable to change attribute type from swatch #17750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2018
Merged

[Forwardport] Unable to change attribute type from swatch #17750

merged 2 commits into from
Sep 11, 2018

Conversation

nmalevanec
Copy link
Contributor

Original Pull Request

#12771

Unable to change attribute type from swatch to dropdown

  • fixed the process of switching attribute input type

Description

Fixed Magento _Swatches module.

Fixed Issues (if relevant)

  1. Unable to change attribute type from swatch to dropdown  #12695: Unable to change attribute type from swatch to dropdown
  2. Changing Swatches to Drop-down does not remove swatches from existing products #11703: Changing Swatches to Drop-down does not remove swatches from existing products
  3. Color attribute taking swatch instead of Drop down option for configurable options, #9307: Color attribute taking swatch instead of Drop down option for configurable options
  4. Product Attributes Not Updating on Frontend #11403: Product Attributes Not Updating on Frontend
  5. Upgrading to 2.1.7 changed dropdown attributes to swatches #9923: Upgrading to 2.1.7 changed dropdown attributes to swatches

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Aug 23, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-2870 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants