Skip to content

Braintree "Place Order" button is disabled after failed validation #12900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ifekaj opened this issue Dec 28, 2017 · 5 comments
Closed

Braintree "Place Order" button is disabled after failed validation #12900

ifekaj opened this issue Dec 28, 2017 · 5 comments
Assignees
@YevSent
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@ifekaj
Copy link

ifekaj commented Dec 28, 2017

Preconditions

  1. Magento 2.2.2
  2. PHP 7.0.25

Steps to reproduce

  1. Add product to cart and proceed to checkout
  2. Fill all customer data and select shipping method. Proceed to payment
  3. Select Braintree credit card payment method
  4. Input credit card number (dummy)
  5. Omit expiry date or cvv
  6. Click "Place order" button
  7. Error "Payment Credit Card (Braintree) can't be initialized" briefly appears
  8. Input expiry date or cvv
  9. "Place order" button is disabled/not responsive

Expected result

  1. "Place order" button can be clicked and order placed

Actual result

  1. "Place order" becomes unresponsive/disabled

Please note that if I input correct expiry date and cvv, order goes through correctly.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 28, 2017
@YevSent YevSent changed the title Braintree (sandbox) checkout problem Braintree "Place Order" button is disabled after failed validation Dec 28, 2017
@YevSent YevSent added Release Line: 2.2 bug report Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Dec 28, 2017
@YevSent YevSent self-assigned this Dec 28, 2017
@YevSent YevSent mentioned this issue Dec 28, 2017
Merged
4 tasks
@YevSent YevSent added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Dec 28, 2017
@magento-engcom-team magento-engcom-team added Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 28, 2017
@magento-team
Copy link
Contributor

Hi @ifekaj. Thank you for your report.
The issue has been fixed in #12902 by @joni-jones in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 3, 2018
magento-team pushed a commit that referenced this issue Jan 3, 2018
@ishakhsuvarov
MAGETWO-86112: Fix #12900: Braintree 'Place Order' button is disabled…
737d0d2 
… after failed validation #12902

 - Merge Pull Request #12902 from joni-jones/magento2:G#12900
 - Merged commits:
   1. 0c5cb6a
magento-team pushed a commit that referenced this issue Jan 3, 2018
@ishakhsuvarov
MAGETWO-86112: Fix #12900: Braintree "Place Order" button is disabled…
6d7ee26 
… after failed validation #12902
@franckgarnier21
Copy link

franckgarnier21 commented Jan 8, 2018 •
edited
Loading

I have the same issue when T&C checkbox is enabled. I think you need to do the same fix an agreement-validator.js

I should have inject Magento_Braintree/js/view/payment/method-renderer/cc-form in the agreement-validator.js and call ccform().isPlaceOrderActionAllowed(true); at the end of the validate function.

It is a hot fix, I let you find the correct fix.

Thanks,

@magento-engcom-team
Copy link
Contributor

Hi @ifekaj. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1299 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@aniruddhadeshpande
Copy link

@franckgarnier21 ,

Are you able to fix this issue? I'm getting same problem on Magento 2.2. BrainTree and TC checkbox enabled.

@aniruddhadeshpande aniruddhadeshpande mentioned this issue Mar 30, 2018
Closed
@deepakgairola25
Copy link

There is another error in verion 2.3 with disabling Place order button
Steps to reproduce

  1. Add product to cart and proceed to checkout
  2. leave email address field blank
  3. Select Braintree credit card payment method
  4. Input credit card number (dummy)
  5. input expiry date and cvv
  6. make sure that email id field is blank
  7. fill customer data (name and address field)
  8. Click update button
  9. Click "Place order" button
  10. Error for email address "This is a required field."
  11. put email address
  12. "Place order" button is disabled/not responsive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YevSent YevSent

Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@magento-team @YevSent @aniruddhadeshpande @deepakgairola25 @franckgarnier21 @ifekaj @magento-engcom-team