Skip to content

Change zip code validation pattern for Japan #14072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HirokazuNishi opened this issue Mar 13, 2018 · 5 comments
Closed

Change zip code validation pattern for Japan #14072

HirokazuNishi opened this issue Mar 13, 2018 · 5 comments
Assignees
@osrecio
Labels
Event: distributed-cd Distributed Contribution Day Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs

Comments

@HirokazuNishi
Copy link
Contributor

Preconditions

  1. magento 2.3.x
  2. magento 2.2.x
  3. magento 2.1.x
  4. magento 2.0.x

Steps to reproduce

  1. Add one more item into cart
  2. Proceed checkout step
  3. Choose "Japan" for country
  4. Set zip code like "123" or "123-4567"
  5. If you set other pattern, you may get validation error message.

Expected result

  1. "1234567" or "123-4567" only can pass the validation. Since 1998, Japanese postoffice only uses 7 digits for zipcode.

Actual result

  1. 123 is not a valid pattern, but actually recognized as a valid pattern. 7 digits of number should be allowed instead of existing pattern_2.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 13, 2018
HirokazuNishi added a commit to Veriteworks/magento2 that referenced this issue Mar 13, 2018
@HirokazuNishi
fix Japanese zip code pattern magento#14072
1d1700e
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Mar 13, 2018
@magento-engcom-team
Copy link
Contributor

@HirokazuNishi , thank you for your report.
We've acknowledged the issue and added to our backlog.

@ishakhsuvarov ishakhsuvarov added up for grabs Event: distributed-cd Distributed Contribution Day labels Mar 15, 2018
@osrecio osrecio self-assigned this Mar 24, 2018
@osrecio
Copy link
Member

osrecio commented Mar 24, 2018

Working on it #distributed-cd

@magento-engcom-team
Copy link
Contributor

@osrecio thank you for joining. Please accept team invitation here and self-assign the issue.

This was referenced Mar 24, 2018
Merged
Merged
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @HirokazuNishi. Thank you for your report.
The issue has been fixed in #14300 by @osrecio in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team added a commit that referenced this issue Mar 26, 2018
@magento-engcom-team
ENGCOM-1052: [ForwardPort 2.3] [#14072] Add Zip Pattern for Japan JP #…
2d75e82 
…14300

 - Merge Pull Request #14300 from osrecio/magento2:PR_14072_2.3
 - Merged commits:
   1. 79474ca
   2. 1e735aa
magento-engcom-team pushed a commit that referenced this issue Mar 26, 2018
ENGCOM-1052: [ForwardPort 2.3] [#14072] Add Zip Pattern for Japan JP #…
a077c54 
…14300
@magento-engcom-team
Copy link
Contributor

Hi @HirokazuNishi. Thank you for your report.
The issue has been fixed in #14299 by @osrecio in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 28, 2018
magento-engcom-team added a commit that referenced this issue Mar 28, 2018
@magento-engcom-team
ENGCOM-1053: [#14072 2.2] Add Zip Pattern for Japan JP #14299
44086a5 
 - Merge Pull Request #14299 from osrecio/magento2:PR_14072_2.2
 - Merged commits:
   1. 6b6ce0a
   2. af6bbfd
magento-engcom-team pushed a commit that referenced this issue Mar 28, 2018
@rostyslav-hymon
ENGCOM-1053: [#14072 2.2] Add Zip Pattern for Japan JP #14299
0f825e1
magento-engcom-team pushed a commit that referenced this issue Mar 28, 2018
ENGCOM-1053: [#14072 2.2] Add Zip Pattern for Japan JP #14299
1ec52cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osrecio osrecio

Labels
Event: distributed-cd Distributed Contribution Day Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@HirokazuNishi @osrecio @ishakhsuvarov @magento-engcom-team