Skip to content

[ForwardPort 2.3] [#14072] Add Zip Pattern for Japan JP#14300

Merged
magento-engcom-team merged 2 commits into
magento:2.3-developfrom
osrecio:PR_14072_2.3
Mar 26, 2018
Merged

[ForwardPort 2.3] [#14072] Add Zip Pattern for Japan JP#14300
magento-engcom-team merged 2 commits into
magento:2.3-developfrom
osrecio:PR_14072_2.3

Conversation

@osrecio

@osrecio osrecio commented Mar 24, 2018

Copy link
Copy Markdown
Member

Add validation for Zip Code in Japan

Description

"1234567" or "123-4567" only can pass the validation. Since 1998, Japanese postoffice only uses 7 digits for zipcode.

Fixed Issues (if relevant)

  1. Change zip code validation pattern for Japan #14072: Change zip code validation pattern for Japan

Manual testing scenarios

  1. Add one more item into cart
  2. Proceed checkout step
  3. Choose "Japan" for country
  4. Set zip code like "123-4567" or "123-4567"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Event: distributed-cd Distributed Contribution Day Progress: accept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants