Skip to content

Duplicate bundle product's child products issue. #14112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kunj1988 opened this issue Mar 15, 2018 · 16 comments
Closed

Duplicate bundle product's child products issue. #14112

kunj1988 opened this issue Mar 15, 2018 · 16 comments
Assignees
@hostep
Labels
Event: kharkivcd19 Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@kunj1988
Copy link
Contributor

kunj1988 commented Mar 15, 2018 •
edited
Loading

When we create duplicate bundle product from Ex. Sprite Yoga Companion Kit > Sprite Yoga Companion Kit 1 and after duplication while we delete duplicate product(Ex. Sprite Yoga Companion Kit 1) from grid main product "(Ex. Sprite Yoga Companion Kit)" options also removed.

Preconditions

  1. Magento version 2.2.1
  2. Magento version 2.2.2
  3. Magento version 2.2.3

Steps to reproduce

  1. First create new bundle product.
  2. edit last created bundle product and click on save and duplicate.
  3. Now go on product grid page and delete last duplicated product.
  4. Open first main product, magento deleting main product's selected child.

Expected result

  1. While creating duplicate product of bundle product magento should create new child options.

Actual result

  1. sprite yoga companion kit products main product we will create duplicate product from this

  2. sprite yoga companion kit before duplicate it

  3. sprite yoga companion kit product duplicate product

  4. sprite yoga companion kit duplicate products bundle item

  5. products inventory catalog delete duplicate product from grid

  6. products inventory catalog deleted duplicate product

  7. sprite yoga companion kit products bundle item delete after delete duplicate product
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Mar 15, 2018
@paragpadsumbiya
Copy link

@kunj1988 thank you for your report.
Please use the issue reporting guidelines to report an issue. Please, edit issue description and include the preconditions, the steps required to reproduce, the actual result, and the expected result.
Please, add the following information:

Preconditions: Magento version
Steps to reproduce
Expected result
Actual result

Can you please provide detialed information so we can check this .

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Progress: needs update labels Mar 16, 2018
@magento-engcom-team
Copy link
Contributor

@kunj1988, thank you for your report. We've acknowledged the issue and added to our backlog.
Please watch the video about how to reproduce this issue.

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Mar 16, 2018
@KalaiarasanSeetharaman
Copy link

I am working on it #dmcdindia

@kunj1988
Copy link
Contributor Author

Please review my commit, I have tried to resolve this issue.

Resolved #14112 : Duplicate bundle product's child products issue.

@magento-engcom-team
Copy link
Contributor

Hi @kunj1988
Could you please submit a Pull Request to this repository with your fix? Thank you

@riccardougolini
Copy link

#perugia

@magento-engcom-team
Copy link
Contributor

@riccardougolini thank you for joining. Please accept team invitation here and self-assign the issue.

@riccardougolini riccardougolini self-assigned this Jun 9, 2018
riccardougolini added a commit to riccardougolini/magento2 that referenced this issue Jun 10, 2018
@riccardougolini
Fix issue magento#14112
2a67fd7 
- set null OptionId
- set null all ProductLink

to prevent overwrite of duplicated bundle product in table `catalog_product_bundle_selection`
riccardougolini added a commit to riccardougolini/magento2 that referenced this issue Jun 11, 2018
@riccardougolini
Fix issue magento#14112
4a460a0 
- fix CS
riccardougolini added a commit to riccardougolini/magento2 that referenced this issue Jun 12, 2018
@riccardougolini
Fix issue magento#14112
421e46d 
- Code style and bug fix
@kunj1988
Copy link
Contributor Author

kunj1988 commented Dec 4, 2018

@magento-engcom-team Is this merged on Magento 2.2 and 2.3?

@riccardougolini riccardougolini self-assigned this Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 8, 2019 •
edited by riccardougolini
Loading

Hi @riccardougolini. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@riccardougolini
Copy link

riccardougolini commented Mar 8, 2019 •
edited
Loading

not reproducible for Magento 2.3 @magento-engcom-team

@GalichMolodothon
Copy link

#kharkivcd19

@magento-engcom-team
Copy link
Contributor

@GalichMolodothon thank you for joining. Please accept team invitation here and self-assign the issue.

@GalichMolodothon
Copy link

not reproducible for Magento 2.2 @magento-engcom-team

@hostep hostep mentioned this issue Sep 23, 2019
Merged
4 tasks
@ghost ghost assigned hostep and unassigned riccardougolini Sep 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kunj1988. Thank you for your report.
The issue has been fixed in #24703 by @hostep in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.4 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 27, 2019
@YiffyToys
Copy link

We can reproduce this issue again in 2.4.7-p1. There seems to be a refression.
However there is no need for deletion to reproduce it.
After duplication and doing any edits on the duplicated product, all bundled options of the original product are empty.

@hostep
Copy link
Contributor

hostep commented Jun 27, 2024

@YiffyToys: this is a really old issue, it's probably a better idea to open a new one and if you think this one is relevant, link to it from the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hostep hostep

Labels
Event: kharkivcd19 Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@hostep @sdzhepa @ishakhsuvarov @kunj1988 @KalaiarasanSeetharaman @magento-engcom-team @GalichMolodothon @paragpadsumbiya @riccardougolini @YiffyToys