-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Forward port fix to keep bundle options in bundle after duplicating it #24703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward port fix to keep bundle options in bundle after duplicating it #24703
Conversation
Hi @hostep. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @hostep, |
Hmm, I think it might be something different, otherwise the "actual results" would also show up. I'll try to somehow setup the integration tests on my local a bit later this week and try to figure it out from there. Thanks for the feedback! |
0f2ff6d
to
629fcdf
Compare
Ok figured it out, was able to reproduce on my local and fix it as well. |
Thanks @ihor-sviziev and @hostep |
@magento give me test instance |
Hi @kalpmehta. Thank you for your request. I'm working on Magento instance for you |
Hi @kalpmehta, here is your new Magento instance. |
Hi @kalpmehta, thank you for the review. |
✔️ QA passed |
Hi @hostep, thank you for your contribution! |
Description (*)
This is a forward port of https://github.com/magento-engcom/magento2ce/pull/1217 which got included in Magento 2.2.4 but somehow didn't make it in the
2.3-develop
branch.Since the PR mentioned above isn't publicly viewable, I have no idea what is mentioned inside it.
But this fixes the fact that when duplicated a bundle product in the backend of Magento, it will still keeps the bundled options associated to the original product.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
None
Contribution checklist (*)