Skip to content

Fix simple products unlink from original bundle product #25017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

MaxSouza
Copy link
Contributor

Description (*)

If bundle product was duplicated - simple products unlink from original bundle product.

Fixed Issues (if relevant)

  1. Duplicating product functionality doesn't support bundle products #24757: Duplicating product functionality doesn't support bundle products

Manual testing scenarios (*)

  1. Go to edit bundle product at the admin
  2. Hit save and duplicate btn
  3. After save, check if the old bundle still has items

Questions or comments

The product that it will be duplicate

image

image

The product that it has been duplicate

image

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@MaxSouza MaxSouza requested a review from akaplya as a code owner October 12, 2019 13:08
@m2-assistant
Copy link

m2-assistant bot commented Oct 12, 2019

Hi @MaxSouza. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@aleron75
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @aleron75. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, here is your new Magento instance.
Admin access: https://pr-25017.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@aleron75
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @aleron75. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@aleron75 aleron75 self-assigned this Oct 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, here is your Magento instance.
Admin access: https://i-25017-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@aleron75
Copy link
Contributor

Sorry @MaxSouza but I didn't manage to reproduce the issue.

I created 4 simple products, made the first bundle, associated two simple products to option 1, associated the other two products to option 2, enabled bundle, hit save+duplicate, enabled new bundle, hit save.

Both bundle products have identical options and associated products both in vanilla M2.3 and in M2.3 + your code.

What am I missing?

@MaxSouza
Copy link
Contributor Author

Hi @aleron75 ,

It's correct, without my code both bundle products does not identical. Could you test without my changes?

@hostep
Copy link
Contributor

hostep commented Oct 13, 2019

Hi @MaxSouza: I think I might have already fixed this a few weeks ago in: #24703

Can you confirm?

@MaxSouza
Copy link
Contributor Author

Hi @hostep,

I confirmed, it's fixed.

@MaxSouza MaxSouza closed this Oct 13, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2019

Hi @MaxSouza, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@MaxSouza MaxSouza deleted the bugfix-24757 branch October 13, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants