-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Mass import - Bunch additional tag to cache context (too many / big requests varnish) #29052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Coosos. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
|
Hi @engcom-Delta. Thank you for working on this issue.
|
Hello @Coosos |
Hi @ihor-sviziev. Thank you for working on this issue.
|
Hi, I will test this as soon as possible |
@Coosos any updates? Does this issue still valid? |
Hi, Sorry for my long response time. Import product file : test_catalog_product_import.csv.gz Varnish logs : varnishlog.gz We can therefore see in the varnish logs that the tags are invalidated several times. If add log in For check
Have the logs, we can see that we are invalidating the already invalidated tags :
Cordially |
Hi @Coosos , I checked issue on 2.4-develop according your steps and get next result:
Result:
My result is differs from your. Could you take a look if my steps are correct or something was missed? |
Hello @engcom-Delta I will watch as soon as possible |
Hi, I just tested with magento 2.4.2, and I did not reproduce this bug (I provoke this on 2.4.1) :) However, I do not know which code fixes this. I close this issue, thank you to have seen :) |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
You can add logs in
\Magento\Catalog\Model\Indexer\Product\Category\Action\Rows::execute
between line 91 and 92 for read$this->cacheContext->getIdentities()
content. (Check #29052 (comment) comment for magento 2.4)We see that each bunch (
\Magento\CatalogImportExport\Model\Import\Product::_saveStockItem
), we have the products already invalidated previously as well as the new, let's repeat an invalidation on a product already previously invalidatedWith 204 products to import:
The text was updated successfully, but these errors were encountered: