Skip to content

Fix LowStock report in All Websites view #10935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Conversation

Linek
Copy link
Contributor

@Linek Linek commented Sep 17, 2017

Fix issue #10595 .

Description

The issue was that lowstock report didn't display products on All Websites view.
The reason is that $storeId variable was not correctly initialized as null and that store filter was applied even if $storeId was null.

Fixed Issues (if relevant)

  1. Low Stock Report Grid Empty #10595: Low Stock Report Grid Empty

Manual testing scenarios

Before Fix

  1. Create new Simple product with qty=0 and Out Of Stock
  2. Open Report->Low Stock
  3. You will not see your product on the grid. You can see it if you will change Scope to storeview

After Fix

  1. Create new Simple product with qty=0 and Out Of Stock
  2. Open Report->Low Stock
  3. You should see your newly created product
  4. Additionally you can create new website with new store and storeview. Then assign product to newly created website and check if grid still works correctly (display product on All Websites and on newly created website, but not on the website where products is not assigned to).

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 17, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov added this to the September 2017 milestone Sep 17, 2017
@ishakhsuvarov
Copy link
Contributor

@Linek Please sign the CLA with the email you have used to commit so we can proceed with review and merge.

@Linek Linek changed the title Add Initilized storeId as null when All Websites set in grid. Removed… Fix LowStock report in All Websites view Sep 17, 2017
@Linek
Copy link
Contributor Author

Linek commented Sep 17, 2017

@ishakhsuvarov CLA signed

@ishakhsuvarov
Copy link
Contributor

@Linek Thank you!

@gwharton
Copy link
Contributor

I'm sorry, I am new to github so forgive my naivety. What is the process of getting this backported into 2.2-develop so the current release gets this fix?

magento-engcom-team added a commit that referenced this pull request Feb 27, 2018
… Websites view #13682

 - Merge Pull Request #13682 from gwharton/magento2:2.2-develop-10595
 - Merged commits:
   1. bf941eb
magento-engcom-team added a commit that referenced this pull request Feb 27, 2018
Accepted Public Pull Requests:
 - #13830: Minicart should require dropdownDialog (by @amenk)
 - #13811: Added missing event parameter for proxy function on the search form submit (by @koenner01)
 - #13816: Add @api annotation to block argument marker interface (by @Vinai)
 - #13777: Fix #13315. Mobile 'Payments methods' step looks bad on mobile (by @Frodigo)
 - #13682: [Backport-2.2] of PR-#10935 Fix LowStock report in All Websites view (by @gwharton)
 - #13700: Fix faulty admin spinner animation (by @RNanoware)


Fixed GitHub Issues:
 - #13791: Submitting search form (mini) with empty value throws error on preventDefault (reported by @koenner01) has been fixed in #13811 by @koenner01 in 2.2-develop branch
   Related commits:
     1. 60bfd47

 - #13315: Mobile "Payment Methods" step looks bad on mobile (reported by @ihor-sviziev) has been fixed in #13777 by @Frodigo in 2.2-develop branch
   Related commits:
     1. db7d299

 - #10595: Low Stock Report Grid Empty (reported by @gwharton) has been fixed in #13682 by @gwharton in 2.2-develop branch
   Related commits:
     1. bf941eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants