-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix LowStock report in All Websites view #10935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… second filtering on collection. magento#10595
@ishakhsuvarov CLA signed |
@Linek Thank you! |
This was referenced Sep 20, 2017
magento-team
pushed a commit
that referenced
this pull request
Sep 27, 2017
I'm sorry, I am new to github so forgive my naivety. What is the process of getting this backported into 2.2-develop so the current release gets this fix? |
4 tasks
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 27, 2018
magento-engcom-team
added a commit
that referenced
this pull request
Feb 27, 2018
Accepted Public Pull Requests: - #13830: Minicart should require dropdownDialog (by @amenk) - #13811: Added missing event parameter for proxy function on the search form submit (by @koenner01) - #13816: Add @api annotation to block argument marker interface (by @Vinai) - #13777: Fix #13315. Mobile 'Payments methods' step looks bad on mobile (by @Frodigo) - #13682: [Backport-2.2] of PR-#10935 Fix LowStock report in All Websites view (by @gwharton) - #13700: Fix faulty admin spinner animation (by @RNanoware) Fixed GitHub Issues: - #13791: Submitting search form (mini) with empty value throws error on preventDefault (reported by @koenner01) has been fixed in #13811 by @koenner01 in 2.2-develop branch Related commits: 1. 60bfd47 - #13315: Mobile "Payment Methods" step looks bad on mobile (reported by @ihor-sviziev) has been fixed in #13777 by @Frodigo in 2.2-develop branch Related commits: 1. db7d299 - #10595: Low Stock Report Grid Empty (reported by @gwharton) has been fixed in #13682 by @gwharton in 2.2-develop branch Related commits: 1. bf941eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #10595 .
Description
The issue was that lowstock report didn't display products on All Websites view.
The reason is that $storeId variable was not correctly initialized as null and that store filter was applied even if $storeId was null.
Fixed Issues (if relevant)
Manual testing scenarios
Before Fix
After Fix
Contribution checklist