FIX for #11166 Index Handling Fatal Error#11183
Merged
okorshenko merged 2 commits intoOct 12, 2017
Merged
Conversation
vrann
suggested changes
Oct 2, 2017
| $state->save(); | ||
| $this->getView()->resume(); | ||
| throw $exception; | ||
| }catch (\Error $error) { |
Contributor
There was a problem hiding this comment.
- please add space before catch
- is there more specific exception you can catch?
Member
Author
There was a problem hiding this comment.
It not so easy to a more specific exception:
Currently, php7 throw much different but you must catch all to set the correct state for the indexer. After a fatal, the indexer must be on state invalid
vrann
approved these changes
Oct 11, 2017
Contributor
|
Nice, thanks @larsroettig! I think this fix should be backported to Magento 2.1.x, would be appreciated if someone is willing to do this. |
Member
Author
Contributor
|
@larsroettig: ah yes, you have a valid point there! We could add a dependency to https://github.com/symfony/polyfill-php70 to get around this, but that's probably a bit out of scope and might introduce new problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #11166