-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Issue #6924: Unmask exception message during product import #11363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Probably a typo. Exception message was passed as a exception description argument instead of exception message. Artefact of optional parameters.
Tests will most likely fail as Travis has issues today initializing test suites (see other builds). |
Re-opening pull request in order to re-run Travis build. |
Very useful! Still an error on 2.2.0... Too hard to fix? |
@tim-bezhashvyly, @iDevid could you confirm that file attached in comment produces general exception error? How can be created the import file with 'broken encoding'? |
@TomashKhamlai it gives me general error, I removed the line and then it gives me an Encoding error, so I encoded the csv in UTF-8 then it works! |
Excuse me @iDevid if I will ask a stupid question but I still do not understand how to produce a general exception error. Should I remove the first line, the last line or any of the lines in the import file that I am going to import? Or could you just attach the file that has 'broken encoding' and will cause the general exception error? |
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-82954: Admin product search - Pressing enter does not submit #4696 #11827 - MAGETWO-82953: Fix #11581: Reference to wrong / non-existing class #11830 - MAGETWO-82887: X-Magento-Tags header containing whitespaces causes exception #11767 - MAGETWO-82886: Improve error reporting for products images import. #11779 - MAGETWO-82754: Magento setup:install interactive shell #11425 - MAGETWO-81594: Issue #6924: Unmask exception message during product import #11363
Description
Probably a typo. Exception message was passed as a exception description argument instead of exception message. Artefact of optional parameters.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist