Skip to content

Issue #6924: Unmask exception message during product import #11363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Issue #6924: Unmask exception message during product import #11363

merged 1 commit into from
Oct 28, 2017

Conversation

tim-bezhashvyly
Copy link

@tim-bezhashvyly tim-bezhashvyly commented Oct 11, 2017

Description

Probably a typo. Exception message was passed as a exception description argument instead of exception message. Artefact of optional parameters.

Fixed Issues (if relevant)

  1. Magento 2.1.0 - "General system exception happened" on Import .csv #6924: Magento 2.1.0 - "General system exception happened" on Import .csv

Manual testing scenarios

  1. Import product CSV with broken encoding

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Probably a typo. Exception message was passed as a exception description argument instead of exception message. Artefact of optional parameters.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 11, 2017

CLA assistant check
All committers have signed the CLA.

@tim-bezhashvyly
Copy link
Author

Tests will most likely fail as Travis has issues today initializing test suites (see other builds).

@tim-bezhashvyly
Copy link
Author

Re-opening pull request in order to re-run Travis build.

@iDevid
Copy link

iDevid commented Oct 23, 2017

Very useful!

Still an error on 2.2.0... Too hard to fix?

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Oct 25, 2017

@tim-bezhashvyly, @iDevid could you confirm that file attached in comment produces general exception error? How can be created the import file with 'broken encoding'?

@iDevid
Copy link

iDevid commented Oct 25, 2017

@TomashKhamlai it gives me general error, I removed the line and then it gives me an Encoding error, so I encoded the csv in UTF-8 then it works!

@TomashKhamlai
Copy link
Contributor

Excuse me @iDevid if I will ask a stupid question but I still do not understand how to produce a general exception error. Should I remove the first line, the last line or any of the lines in the import file that I am going to import? Or could you just attach the file that has 'broken encoding' and will cause the general exception error?

@okorshenko okorshenko merged commit 4cdc133 into magento:2.2-develop Oct 28, 2017
okorshenko pushed a commit that referenced this pull request Oct 28, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82954: Admin product search - Pressing enter does not submit #4696 #11827
 - MAGETWO-82953: Fix #11581: Reference to wrong / non-existing class #11830
 - MAGETWO-82887: X-Magento-Tags header containing whitespaces causes exception #11767
 - MAGETWO-82886: Improve error reporting for products images import. #11779
 - MAGETWO-82754: Magento setup:install interactive shell #11425
 - MAGETWO-81594: Issue #6924: Unmask exception message during product import #11363
@tim-bezhashvyly tim-bezhashvyly deleted the patch-1 branch October 30, 2017 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants